Fix deprecation warnings

[soapy1]

Description

There are currently lots of deprecation warning when running the test suite. Some of them come from upstream dependencies. But many are from conda-store. This PR aims to resolve some of them.

not fixed:

• datetime.datetime.utcnow is deprecated, should be replaced with datetime.datetime.now(datetime.UTC). However, this is not supported by python 3.10. Will address this when we drop python 3.10 support

Pull request checklist

• Did you test this change locally?
• Did you update the documentation (if required)?
• Did you add/update relevant tests for this change (if required)?

[netlify]

✅ Deploy Preview for conda-store canceled.

Name	Link
🔨 Latest commit	d0bafb2
🔍 Latest deploy log	https://app.netlify.com/sites/conda-store/deploys/67573704f000600008eabc78

[netlify]

✅ Deploy Preview for conda-store ready!

Name	Link
🔨 Latest commit	cad48b9
🔍 Latest deploy log	https://app.netlify.com/sites/conda-store/deploys/67608b4efcf9dd000898b1ba
😎 Deploy Preview	https://deploy-preview-1013--conda-store.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[trallard]

I did not go through all the changes in detail but this is much appreciated.

datetime.datetime.utcnow is deprecated, should be replaced with datetime.datetime.now(datetime.UTC). However, this is not supported by python 3.10. Will address this when we drop python 3.10 support

Can you add a TODO note on this in the code so we do not forget to do this when needed

[peytondmurray]

See comment below about python 3.10/utcnow issue. I vote for a github issue and the suggested snippet instead of TODOs everywhere, but I'd be okay if you wanted to merge this as is too.

[peytondmurray]

Can we make an issue for this instead of inline TODOs? I know adding them was suggested before but they have a habit of getting lost in the repo if there aren't issues for them...

To mitigate datetime deprecation warnings, we could also do something like this at the top of the file (or in a utils.py) so that the correct function is called on whatever version is currently running:

import sys

if sys.version_info[:2] > (3, 10):
    from datetime.datetime import now
else:
    from datetime.datetime import utcnow as now

[soapy1]

ooo, I like the suggestion of making this an issue opposed to TODO's.

For the deprecation warnings, I don't think this snippet is going to quite work. datetime.datetime.now will use the default TZ provided by the machine it's running on if it's not given the timezone parameter. And utcnow does not accept any arguments. So on my machine (I'm on Pacific time) I get

>>> datetime.datetime.now()
datetime.datetime(2024, 12, 16, 12, 10, 50, 437991)

>>> datetime.datetime.utcnow()
. . .  deprecation warning removed for brevity . . .
datetime.datetime(2024, 12, 16, 20, 11, 2, 237286)

>>> datetime.datetime.utcnow(datetime.UTC)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: datetime.utcnow() takes no arguments (1 given)

[soapy1]

link to issue: #1025

[peytondmurray]

Ahh, I guess it would have to be something like

import sys

if sys.version_info[:2] > (3, 10):
    from datetime.datetime import now
else:
    import datetime
    def now():
        return datetime.datetime.utcnow(datetime.UTC)

But I'm fine with just merging as is if that's preferable.

[soapy1]

Cool, I'm going to go for a merge so we have less work in the future when we can drop python 3.10