Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant channel column #1010

Merged
merged 10 commits into from
Jan 8, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Dec 5, 2024

Fixes #994

Description

The primary focus of this pr is to remove the channel_id column and channel association in the conda_package_build table. This is redundant information, also available in the associated package. In order to get channel information from a conda_package_build users may join the conda_package table and conda_package_build table. For example:

from conda_store_server._internal import orm

db.query(orm.CondaPackageBuild)
        .join(orm.CondaPackage)
        .filter(orm.CondaPackage.channel_id == 1)

Things changed in this PR:

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional Info

Part of the migration is to correct some of the conda_package_build entries that have the wrong conda_package associated with them. Since this needs to sort thru all elements of this table, this migration takes a while to run. Users should probably opt to run this migration directly with alembic.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 3a76258
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6751f6f5d17be90008e77ea8
😎 Deploy Preview https://deploy-preview-1010--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 2371448
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67786b9a07a46a000841cf74

@soapy1 soapy1 force-pushed the remove-redundant-channel branch 6 times, most recently from 163f1f3 to f1690bb Compare December 6, 2024 01:36
@soapy1 soapy1 marked this pull request as ready for review December 6, 2024 01:36
@soapy1 soapy1 marked this pull request as draft December 6, 2024 15:41
@soapy1 soapy1 force-pushed the remove-redundant-channel branch from 84b22b1 to 86ffd89 Compare December 6, 2024 21:05
@soapy1 soapy1 marked this pull request as ready for review December 6, 2024 21:23
@soapy1 soapy1 marked this pull request as draft December 16, 2024 20:21
@soapy1 soapy1 force-pushed the remove-redundant-channel branch from 74793f7 to ebe9c21 Compare December 16, 2024 23:18
@soapy1 soapy1 marked this pull request as ready for review December 16, 2024 23:19
@peytondmurray peytondmurray self-requested a review January 3, 2025 19:12
@peytondmurray
Copy link
Contributor

At least partially address #733 with the addition of pytest-alembic.

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seemed like a bit of a tricky migration. The changes look great, thank you for this! Only a few minor suggestions here.

@soapy1 soapy1 force-pushed the remove-redundant-channel branch from 2280bf2 to 56f2552 Compare January 3, 2025 22:58
@soapy1 soapy1 merged commit 1523801 into conda-incubator:main Jan 8, 2025
30 checks passed
@soapy1 soapy1 deleted the remove-redundant-channel branch January 8, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[MAINT] - Remove redundant column "channel" in conda_package_build table
2 participants