-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant channel column #1010
Conversation
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for conda-store canceled.
|
163f1f3
to
f1690bb
Compare
84b22b1
to
86ffd89
Compare
This information is duplicated by the package relationship. For example, the package table already keeps track of the package channel.
This will: * fix bad db entries * remove channel id from conda_package_build table
74793f7
to
ebe9c21
Compare
At least partially address #733 with the addition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seemed like a bit of a tricky migration. The changes look great, thank you for this! Only a few minor suggestions here.
...rver/tests/_internal/alembic/version/test_89637f546129_remove_conda_package_build_channel.py
Show resolved
Hide resolved
...rver/tests/_internal/alembic/version/test_89637f546129_remove_conda_package_build_channel.py
Show resolved
Hide resolved
2280bf2
to
56f2552
Compare
Fixes #994
Description
The primary focus of this pr is to remove the
channel_id
column andchannel
association in theconda_package_build
table. This is redundant information, also available in the associatedpackage
. In order to get channel information from aconda_package_build
users may join theconda_package
table andconda_package_build
table. For example:Things changed in this PR:
channel_id
column in theconda_package_build
tableconda_package_build
to have the correct package associated with each row. See Update conda-package-build causes an integrity error on conda_package_build table #961 for more details about this issuePull request checklist
Additional Info
Part of the migration is to correct some of the conda_package_build entries that have the wrong conda_package associated with them. Since this needs to sort thru all elements of this table, this migration takes a while to run. Users should probably opt to run this migration directly with alembic.