Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use quansight/conda-store docker image #1004

Merged

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Nov 27, 2024

Fixes #626

Description

As we prepare to consolidate the conda-store and conda-store-server packages (as per #911) we'll need to move away from using artifacts generated from the conda-store release.

This PR updates:

  • the docker examples to not use the conda-store docker image
  • fixes the docker examples so that users can log in with jpuyter oauth and create environments

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 53c4318
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67575cc7a7ce4d0008f55923

@soapy1 soapy1 force-pushed the dont-use-conda-store-docker-image branch from 14ee51b to 35e82c2 Compare November 27, 2024 18:40
@soapy1 soapy1 marked this pull request as ready for review November 27, 2024 18:43
@soapy1 soapy1 changed the title Don't use conda store docker image Don't use quansight/conda-store docker image Nov 27, 2024
@soapy1 soapy1 requested a review from peytondmurray December 3, 2024 16:30
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always your changes are great. Most comments are for my own learning and to get context on the changes. 🚀

examples/docker/docker-compose.yaml Show resolved Hide resolved
context: dockerfiles
dockerfile: jupyterhub.Dockerfile
args:
python_version: 3.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is actually something we need to do here (or if there's some reason to be using 3.11), but I vote to target the latest stable version if possible (3.13)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a conda error when running python 3.13

> [jupyterhub 3/7] RUN mamba create --name conda-store     python=3.13 nb_conda_kernels nodejs=18 yarn constructor conda-store     --channel conda-forge -y &&     mamba clean --all -y &&     conda clean --force-pkgs-dirs:                     
14.27                                                                            
14.27 Looking for: ['python=3.13', 'nb_conda_kernels', 'nodejs=18', 'yarn', 'constructor', 'conda-store']
14.27 
14.27 Could not solve for environment specs
14.27 The following packages are incompatible
14.27 ├─ constructor is installable with the potential options
14.27 │  ├─ constructor [1.3.0|1.3.1|...|3.0.1] would require
14.27 │  │  └─ python [2.7* |>=2.7,<2.8.0a0 ], which can be installed;
14.27 │  ├─ constructor [1.3.0|1.3.1|1.3.2|1.3.3|1.3.4] would require
14.27 │  │  └─ python 3.4* , which can be installed;
14.27 │  ├─ constructor [1.3.0|1.3.1|...|2.2.0] would require
14.27 │  │  └─ python [3.5* |>=3.5,<3.6.0a0 ], which can be installed;
14.27 │  ├─ constructor [1.5.5|2.0.0|2.0.1|2.0.2|2.0.3] would require
14.27 │  │  └─ python 3.6* , which can be installed;
14.27 │  ├─ constructor [2.1.0|2.2.0|...|3.2.1] would require
14.27 │  │  └─ python >=3.6,<3.7.0a0 , which can be installed;
14.27 │  ├─ constructor [2.2.0|2.3.0|...|3.3.1] would require
14.27 │  │  └─ python >=3.7,<3.8.0a0 , which can be installed;
14.27 │  ├─ constructor [3.0.2|3.1.0|...|3.3.1] would require
14.27 │  │  └─ python >=3.8,<3.9.0a0 , which can be installed;
14.27 │  ├─ constructor [3.1.0|3.2.0|3.2.1] would require
14.27 │  │  └─ python_abi 3.6 *_pypy36_pp73, which requires
14.27 │  │     └─ python 3.6.* *_73_pypy, which can be installed;
14.27 │  ├─ constructor [3.2.0|3.2.1|3.2.2|3.3.1] would require
14.27 │  │  └─ python >=3.9,<3.10.0a0 , which can be installed;
14.27 │  ├─ constructor [3.2.2|3.3.1] would require
14.27 │  │  └─ python >=3.10,<3.11.0a0 , which can be installed;
14.27 │  ├─ constructor [3.10.0|3.11.0|...|3.9.3] would require
14.27 │  │  └─ __win, which is missing on the system;
14.27 │  ├─ constructor [3.3.1|3.4.1|3.4.2|3.4.3] would require
14.27 │  │  └─ conda [>=4.6,<23.1.0 |>=4.6,<23.1.0a0 ] with the potential options
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.14.0] would require
14.27 │  │     │  └─ python >=3.10,<3.11.0a0 , which can be installed;
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|24.9.2] would require
14.27 │  │     │  └─ python >=3.11,<3.12.0a0 , which can be installed;
14.27 │  │     ├─ conda [22.9.0|4.10.0|...|4.9.2] would require
14.27 │  │     │  └─ python >=3.7,<3.8.0a0 , which can be installed;
14.27 │  │     ├─ conda [22.11.1|22.9.0|4.14.0] would require
14.27 │  │     │  └─ python_abi 3.8 *_pypy38_pp73, which requires
14.27 │  │     │     └─ python 3.8.* *_73_pypy, which can be installed;
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.9.2] would require
14.27 │  │     │  └─ python >=3.8,<3.9.0a0 , which can be installed;
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.14.0] would require
14.27 │  │     │  ├─ pypy3.9 [>=7.3.13 |>=7.3.15 ], which requires
14.27 │  │     │  │  └─ python 3.9.* *_73_pypy, which can be installed;
14.27 │  │     │  └─ python_abi 3.9 *_pypy39_pp73, which requires
14.27 │  │     │     └─ python 3.9.* *_73_pypy, which can be installed;
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.9.2] would require
14.27 │  │     │  └─ python >=3.9,<3.10.0a0 , which can be installed;
14.27 │  │     ├─ conda [4.10.0|4.10.1|...|4.9.2] would require
14.27 │  │     │  └─ python >=3.6,<3.7.0a0 , which can be installed;
14.27 │  │     ├─ conda [4.10.0|4.10.1|...|4.9.2] would require
14.27 │  │     │  └─ python_abi 3.6 *_pypy36_pp73, which can be installed (as previously explained);
14.27 │  │     ├─ conda [4.10.1|4.10.2|...|4.13.0] would require
14.27 │  │     │  └─ python_abi 3.7 *_pypy37_pp73, which requires
14.27 │  │     │     └─ python 3.7.* *_73_pypy, which can be installed;
14.27 │  │     └─ conda [4.6.1|4.6.10|...|4.8.3] would require
14.27 │  │        └─ python >=2.7,<2.8.0a0 , which can be installed;
14.27 │  ├─ constructor [3.10.0|3.11.0|...|3.9.3] would require
14.27 │  │  └─ conda >=4.6  with the potential options
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.14.0], which can be installed (as previously explained);
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|24.9.2], which can be installed (as previously explained);
14.27 │  │     ├─ conda [22.9.0|4.10.0|...|4.9.2], which can be installed (as previously explained);
14.27 │  │     ├─ conda [22.11.1|22.9.0|4.14.0], which can be installed (as previously explained);
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.9.2], which can be installed (as previously explained);
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.14.0], which can be installed (as previously explained);
14.27 │  │     ├─ conda [22.11.1|22.9.0|...|4.9.2], which can be installed (as previously explained);
14.27 │  │     ├─ conda [4.10.0|4.10.1|...|4.9.2], which can be installed (as previously explained);
14.27 │  │     ├─ conda [4.10.0|4.10.1|...|4.9.2], which can be installed (as previously explained);
14.27 │  │     ├─ conda [4.10.1|4.10.2|...|4.13.0], which can be installed (as previously explained);
14.27 │  │     ├─ conda [4.6.1|4.6.10|...|4.8.3], which can be installed (as previously explained);
14.27 │  │     ├─ conda [23.1.0|23.3.0|...|23.7.3] would require
14.27 │  │     │  └─ pypy3.8 >=7.3.11  with the potential options
14.27 │  │     │     ├─ pypy3.8 7.3.11 would require
14.27 │  │     │     │  └─ python 3.8.* *_73_pypy, which can be installed;
14.27 │  │     │     └─ pypy3.8 7.3.11 would require
14.27 │  │     │        └─ python 3.8.* *_7.3_pypy, which can be installed;
14.27 │  │     ├─ conda [23.1.0|23.3.0|...|23.7.4] would require
14.27 │  │     │  └─ pypy3.9 [>=7.3.11 |>=7.3.12 ] with the potential options
14.27 │  │     │     ├─ pypy3.9 [7.3.11|7.3.12|7.3.13|7.3.15|7.3.16], which can be installed (as previously explained);
14.27 │  │     │     └─ pypy3.9 7.3.12 would require
14.27 │  │     │        └─ python 3.9.* *_7.3_pypy, which can be installed;
14.27 │  │     └─ conda [23.10.0|23.11.0|...|24.9.2] would require
14.27 │  │        └─ python_abi 3.12.* *_cp312, which requires
14.27 │  │           └─ python 3.12.* *_cpython, which can be installed;
14.27 │  └─ constructor [3.10.0|3.11.0|3.9.3] would require
14.27 │     └─ __osx, which is missing on the system;
14.27 └─ python 3.13**  is not installable because there are no viable options
14.27    ├─ python [3.13.0|3.13.1] conflicts with any installable versions previously reported;
14.27    └─ python [3.13.0rc1|3.13.0rc2|3.13.0rc3] would require
14.27       └─ _python_rc, which does not exist (perhaps a missing channel).
------

Ok to settle for 3.12?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, last I checked conda hasn't been packaged for 3.13 yet :/

Let's do 3.12.

@soapy1 soapy1 merged commit 3ae8b3c into conda-incubator:main Dec 9, 2024
24 of 26 checks passed
@soapy1 soapy1 deleted the dont-use-conda-store-docker-image branch December 9, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - jupyterhub container doesn't work with sqlalchemy 2.0
2 participants