Remove docker build tasks #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store canceled.
|
soapy1
added
area: api 🌐
area: user experience 👩🏻💻
✅ Deploy Preview for conda-store canceled.
|
soapy1
force-pushed
the
remove-docker-build-tasks
branch
from
c6379fd to
794e95f
Compare
rfc https://datatracker.ietf.org/doc/html/draft-ietf-httpapi-deprecation-header suggests using a "Deprecation" header in the response with the intended deprecation date. We don't have a specific date, so we'll set the value of this header to true.
soapy1
force-pushed
the
remove-docker-build-tasks
branch
from
49c27e7 to
d9a4a66
Compare
soapy1
force-pushed
the
remove-docker-build-tasks
branch
from
b9fe1d9 to
14baab2
Compare
peytondmurray
approved these changes
Dec 6, 2024
| @@ -1341,14 +1340,15 @@ async def api_get_build_archive( | |||
| return RedirectResponse(conda_store.storage.get_url(build.conda_pack_key)) | |||
|
|
|||
|
|
|||
| @router_api.get("/build/{build_id}/docker/") | |||
| @router_api.get("/build/{build_id}/docker/", deprecated=True) | |||
There was a problem hiding this comment.
👍 Thanks for making sure this appears in both the docs and the response.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941
Description
This PR removes actions for building docker images and related functionality, including:
action_generate_conda_docker/build/<build id>/dockerdeprecation: trueWe'll leave in the docker registry functionality. This requires the following docker related bits to stay (to be removed in #942)
DOCKER_build artifact typesPull request checklist