-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] - Test for parallel builds #548
Comments
@costrouc can you help scope this work? Do we need to make some changes to the previous effort or should we take a new direction? |
@kcpevey parallel builds are supported. I don't think any action needs to be taken. We just need a release of conda-store. I'm going to close this issue unless additional work needs to be done. |
Have the bugs we found during the pycon tutorials been fixed? Have we tested parallel builds in anyway? |
Are multiple builds of a single environment also parallel? i.e. I click "Create" for an env to be built, immediately realize I forgot a package, edit the yaml, and click "Create" again. I've done this quite a few times and the second env immediately says "building" but the time it takes to build seems to indicate its waiting for the first build to finish. This is just a suspicion, since I can't really test or see what's happening as an end user. |
reopening until this discussion is resolved. |
Ok, I've been testing on this today. I have a env that takes over an hour to build, call it Note that when you submit an env to be built, it immediately shows "Building" no matter what. What I observed:
I do not think parallel builds are working. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
That's a good point. I'm testing on the nebari instance we have deployed for jatic. We used to be deploying from main, but I dont think that's true for this deployment. |
Added a test in #567. See the discussion there on potential limitations of this test. |
Also, there was this issue regarding DB connections and celery concurrency: #247. Because of this, in all example configs, we set the concurrency value to 4, which might not be enough in some environments(?). But I'm not sure what the current state is, I haven't looked into this DB issue at all. |
@nkaretnikov what is the status with this? |
@trallard A week+ ago, Chris and I agreed this should be tested by making API requests, so that's the new plan. But I haven't started with this so far. Should I prioritize this over all other things assigned to me? Or is there a particular deadline when you want to see this done? |
No need to reprioritise other tasks. I was just checking in. |
Feature description
We need the ability to build environments in parallel. This functionality was added in #392 but there was issues and the work needed to be reverted.
We need to re-implement this feature.
Value and/or benefit
Building all environments in series is not efficient and once there are a number of people on the platform, wait times for builds grows to an unacceptable length of time.
Anything else?
No response
The text was updated successfully, but these errors were encountered: