Fixing the internal vs. external url issue

conda-incubator · Aug 19, 2021 · b47ce2e · b47ce2e
1 parent 9e20005
commit b47ce2e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/conda-store-server/conda_store_server/server/auth.py b/conda-store-server/conda_store_server/server/auth.py
@@ -541,7 +541,7 @@ def _login_html_default(self):
         """
 
 
-class JupyterHub(GenericOAuthAuthentication):
+class JupyterHubOAuthAuthentication(GenericOAuthAuthentication):
     jupyterhub_url = Unicode(
         help="base url for jupyterhub not including the '/hub/'",
         config=True,

diff --git a/tests/assets/conda_store_config.py b/tests/assets/conda_store_config.py
@@ -41,6 +41,12 @@
 c.JupyterHubOAuthAuthentication.jupyterhub_url = "http://jupyterhub"
 c.JupyterHubOAuthAuthentication.client_id = "this-is-a-jupyterhub-client"
 c.JupyterHubOAuthAuthentication.client_secret = "this-is-a-jupyterhub-secret"
+# in the case of docker-compose the internal and external dns
+# routes do not match. Inside the docker compose deployment
+# jupyterhub is accessible via the `jupyterhub` hostname in dns
+# however outside of the docker it is accessible via localhost
+# hence this small change needed for testing
+c.JupyterHubOAuthAuthentication.authorize_url = "http://localhost:8000/hub/api/oauth2/authorize"
 
 # ==================================
 #         worker settings