Add cursor-based pagination for environment listings #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
force-pushed
the
859-cursor-pagination
branch
from
65c3853 to
8693acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to conda-incubator/conda-store#881.
Description
This PR allows the frontend to use the v2 endpoint for the
/environment/endpoint. The main change here is from page-based pagination to cursor-based pagination. The endpoint now returns a base64-encoded cursor. If the user wants to fetch the next page of results, they just pass the cursor as a query parameter, e.g./api/v2/endpoint/?cursor=<cursor string>. The response from the server will contain the cursor for the next page.Pull request checklist