Remove unnecessary scroll bars from specification tables #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
force-pushed
the
prettier-tables
branch
from
e9ab17e to
b388ba8
Compare
gabalafou
commented
Sep 11, 2024
| @@ -47,7 +47,7 @@ export const RequestedPackageList = ({ | |||
| </StyledAccordionSummary> | |||
| <StyledAccordionDetails sx={{ padding: 0 }}> | |||
| <TableContainer> | |||
| <Table sx={{ width: "420px", tableLayout: "fixed" }}> | |||
| <Table sx={{ width: "100%", tableLayout: "fixed" }}> | |||
There was a problem hiding this comment.
I think I previously thought that with table-layout: fixed, I needed to set a concrete width in pixels, but the MDN article on table-layout suggests that a percentage value for the width is fine. The key point is two-fold:
- Must set width to something (cannot leave unspecified)
- Except must not set width to
auto
In order for the browser to respect table-layout: fixed and not use table-layout: auto instead.
| @@ -15,8 +15,8 @@ export const StyledAccordionDetails = styled(AccordionDetails, { | |||
| ? `1px solid ${palette.secondary.light}` | |||
| : "1px solid #BCBFC4", | |||
| borderTop: "none", | |||
| borderRadius: styleType === "grayscale" ? "0px 0px 5px 5px" : "Opx", | |||
| overflowY: "scroll", | |||
| borderRadius: styleType === "grayscale" ? "0px 0px 5px 5px" : "0px", | |||
There was a problem hiding this comment.
The character on the left is not actually the zero numeral
| borderRadius: styleType === "grayscale" ? "0px 0px 5px 5px" : "Opx", | ||
| overflowY: "scroll", | ||
| borderRadius: styleType === "grayscale" ? "0px 0px 5px 5px" : "0px", | ||
| overflowY: "auto", |
There was a problem hiding this comment.
Don't show the vertical scroll bar unless there is actually overflow
gabalafou
force-pushed
the
prettier-tables
branch
from
b388ba8 to
ea41633
Compare
trallard
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
No more unnecessary scroll bars.