Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Update actions #420

Merged
merged 1 commit into from
Sep 9, 2024
Merged

MAINT - Update actions #420

merged 1 commit into from
Sep 9, 2024

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Sep 6, 2024

Description

There are several warnings in our CI about deprecations due to outdated actions.
This PR

  • bumps relevant actions to their latest major release
  • adds some cosmetic changes to keep workflows consistent

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - looks great!

One thing I noticed which you may want to include here is that the release workflow depends on a workflow from specifically main, not the locally checked out version. I'm not sure if this is intended, but I'm guessing we probably want it to be whatever version is checked out on the github runner? Anyway I'm fine if you don't want to bother with this in this PR, but it might be worth changing later.

@trallard
Copy link
Collaborator Author

trallard commented Sep 9, 2024

It should always use main for the release action since it is only triggered on tag creation which should be created off main

@trallard trallard merged commit ecf425f into main Sep 9, 2024
4 of 5 checks passed
@trallard trallard deleted the trallard/update-actions branch September 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants