Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Compose for GitHub Actions #411

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Aug 9, 2024

I think our test-conda-store-ui job is failing because we try to run docker-compose but GitHub recently started removing v1 of Docker Compose, so we should run the v2 command, which is without the hyphen now:

docker compose

@gabalafou
Copy link
Contributor Author

gabalafou commented Aug 9, 2024

Possibly related to CI failure on #401.

I think there were actually two issues with #401. I think that the yarn.lock file I was generating locally did not match the lock file generated on CI, and then on top of that, I think it was failing because of this Docker Compose issue.

@gabalafou gabalafou requested a review from peytondmurray August 9, 2024 10:45
@gabalafou gabalafou mentioned this pull request Aug 9, 2024
3 tasks
@trallard trallard merged commit 5dabe4f into conda-incubator:main Aug 9, 2024
4 checks passed
@gabalafou gabalafou deleted the docker-compose-v2 branch August 19, 2024 09:46
gabalafou added a commit to gabalafou/conda-store-ui that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants