-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lockfile upload #401
Merged
peytondmurray
merged 29 commits into
conda-incubator:main
from
gabalafou:lockfile-upload
Aug 10, 2024
Merged
Lockfile upload #401
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d929963
Support creating lockfile envs
nkaretnikov d1c6f60
Remove redundant import
nkaretnikov e3a83d9
Update state
nkaretnikov 42230f2
Remove workarounds that are no longer needed
nkaretnikov c7f4805
Handle `is_lockfile` in test
nkaretnikov b3fdfd8
Initial edit spec support
nkaretnikov fe424d5
Send updated spec to server
nkaretnikov e6bd472
Get channels from lockfile
nkaretnikov f346820
Get dependencies from lockfile
nkaretnikov d606a17
gabs edits
gabalafou 7b0d4a8
Add warning about no syncing between lockfile and GUI
gabalafou 6ebd16d
Revert unneeded changes
gabalafou c3705d9
Working proof of concept: lockfile upload
gabalafou 61e5a40
Switch to lockfile/specification
gabalafou be078a2
Merge branch 'main' into lockfile-upload
gabalafou 86008f6
Show dependencies and channels for lockfile-built envs
gabalafou 54a1dd1
reset SpecificationEdit when switching builds
gabalafou fd9a585
Kim's suggestions
gabalafou 9626ea0
Show installed dependencies and channels on view environment built fr…
gabalafou 54bf876
lint
gabalafou 2dd8c0a
yarn install
gabalafou dae542c
yarn install (with correct version of yarn this time)
gabalafou 96b4311
note about file formats
gabalafou 6d7a97b
lint
gabalafou be8b847
Three changes:
gabalafou bc3d29f
update yarn.lock
gabalafou 46455ac
Fix Docker Compose for GitHub Actions
gabalafou 0bea284
Merge branch 'main' into lockfile-upload
gabalafou 912ad1f
Merge branch 'docker-compose-v2' into lockfile-upload
gabalafou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
import { CondaSpecificationPip } from "./CondaSpecificationPip"; | ||
import type { CondaSpecificationPip } from "./CondaSpecificationPip"; | ||
import type { Lockfile } from "./Lockfile"; | ||
|
||
export type CondaSpecification = { | ||
name: string; | ||
channels: string[]; | ||
dependencies: (string | CondaSpecificationPip)[]; | ||
variables: Record<string, string>; | ||
prefix?: string | null; | ||
lockfile?: Lockfile; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// TODO: define lockfile type better | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worth making an issue? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the suggestion, done! #413 |
||
export type Lockfile = Record<string, any>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import React from "react"; | ||
import Typography from "@mui/material/Typography"; | ||
|
||
export const LockfileSupportInfo = () => ( | ||
<Typography sx={{ fontSize: "12px" }}> | ||
We currently only support the{" "} | ||
<a | ||
href="https://conda.github.io/conda-lock/" | ||
target="_blank" | ||
rel="noreferrer" | ||
> | ||
Conda lockfile | ||
</a>{" "} | ||
format. Other lockfile formats such as Poetry are not supported. | ||
</Typography> | ||
); | ||
|
||
export default LockfileSupportInfo; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!