Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Playwright timeout patch #342

Closed
wants to merge 3 commits into from
Closed

WIP - Playwright timeout patch #342

wants to merge 3 commits into from

Conversation

trallard
Copy link
Collaborator

Fixes # .

Description

This pull request:

  • a
  • b
  • c

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@kcpevey
Copy link
Contributor

kcpevey commented Nov 28, 2023

The issue is not the timeout. We changed the label for the YAML editor button which broke playwright. I have PR to fix (and add a default timeout of 30s) #343

@trallard trallard closed this Nov 28, 2023
@trallard trallard deleted the trallard/playwright-patch branch December 21, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trallard @kcpevey