Expose status_info in the UI

[nkaretnikov]

Companion PR for conda-incubator/conda-store#653

[nkaretnikov]

This shouldn't be merged before the companion PR lands on the server side.

[nkaretnikov]

Looks like this (prints status_info in parens if available - "build_path too long" on the screenshot here):

Before:

After:

[nkaretnikov]

This has many changes due to formatting. It helps to hide whitespace when reviewing:

[nkaretnikov]

@steff456 I still need to figure out why playwright fails, but is this cool overall? UPD: playwright might be just a flaky test, resolved here: #328.
@smeragoel Any comments on the design (see screenshot)?

[steff456]

@nkaretnikov can you please add a screenshot before the change? In that way it is clearer what's the difference in the UI

[nkaretnikov]

@steff456 #332 (comment) Added before/after.

[nkaretnikov]

This used to fail because data was undefined.

A repro: try to create an environment with 256 a chars as the env name: 'a' * 256. This causes a SQL error on the server because the field is only 255 chars long. With this change, the UI now shows an error message.

I'm not adding a "before" screenshot because before it was just showing nothing - same page you have when you click Create. You could also see an uncaught exception in the dev browser console (that's usually opened by pressing f12).

[steff456]

What are the possible error messages that will be displayed here?

[nkaretnikov]

e?.data?.message corresponds to what used to be here before. I think message is not actually used by the said route, but I would keep it just in case, in case it's changed later. The route on the server is:

api_post_specification
...
return {"status": "ok", "data": {"build_id": build_id}}

Unlike some other routes, it doesn't include the message field.

The new message is always a generic error message shown on the screenshot above. This is what we do elsewhere as well, so it's consistent.

[nkaretnikov]

@steff456 PTAL. Tests now pass, not planning to make more changes.

Do not merge this yet. The companion server PR (conda-incubator/conda-store#653) is not reviewed yet. I'll merge this myself when that one is merged.

[steff456]

I just left a minor comment related to the code. I think this PR first needs approval from @smeragoel to check the design first. This is the first element that will show actual error messages in the UI, so it is important to have a design system for them and also check if we want to have the raw error message displayed.

[steff456]

What are the possible error messages that will be displayed here?

[nkaretnikov]

• Replied to @steff456's comments. I don't think there's anything to be changed here.
• Waiting for @smeragoel to comment on the design. Alternatively, we can just merge this and address design concerns later. It doesn't look like a huge change.
• Before we merge, waiting until the companion PR on the server side is approved.

[smeragoel]

No major design changes, approved from my side!

[steff456]

LGTM! Thanks @nkaretnikov

[nkaretnikov]

Before we merge, waiting until the companion PR on the server side is approved.