Skip to content

Commit

Permalink
separate artifacts for videos and screenshots
Browse files Browse the repository at this point in the history
  • Loading branch information
kcpevey committed Jan 9, 2024
1 parent fe795f2 commit c117a58
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/push_images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ jobs:
pr: ${{ env.PR_NUMBER }}
# how to exit the action if no artifact is found
if_no_artifact_found: fail
# artifact name
name: 'screenshots'

- name: "ls"
run: |
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,16 @@ jobs:
run: |
yarn run start & pytest --video on --output test-results --screenshots true test/playwright/test_ux.py
- name: "Upload artifacts"
- name: "Upload screenshot artifacts"
uses: actions/upload-artifact@v3
if: ${{ always() }}
with:
name: playwright-tests
name: screenshots
path: test-results

- name: "Upload video artifact"
uses: actions/upload-artifact@v3
if: ${{ always() }}
with:
name: video
path: video
2 changes: 1 addition & 1 deletion test/playwright/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ def screenshot(pytestconfig):
def browser_context_args(browser_context_args):
return {
**browser_context_args,
"record_video_dir": "test-results/videos/",
"record_video_dir": "video",
}

0 comments on commit c117a58

Please sign in to comment.