Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg-makedepend v1.0.9 #9

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7777930515, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [15]

@pkgw
Copy link
Contributor

pkgw commented Feb 5, 2024

Windows is hitting an error we've seen in more and more of these packages:

configure.ac:5: error: Autoconf version 2.70 or higher is required

... but note that last month the M2 packages finally got updated after several years, so we have 2.71.3 as an option!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pkgw
Copy link
Contributor

pkgw commented Feb 5, 2024

Current issue is a lack of unistd.h. I'll have to remind myself what to do about that sort of thing in the MSYS2/MinGW framework ...

(Side note, it looks like the posix dep probably can/should be restored.)

@pkgw
Copy link
Contributor

pkgw commented Feb 5, 2024

Ah, yes, I believe that the idea is that the new version won't let you use the Cygwin/MinGW POSIX compatibility libraries; your code has to be compatible with the native Windows APIs without relying on the support libraries. In the particular case of makedepend, that will probably require some relatively invasive patching, although it's a pretty small program overall.

For posterity, here are the changes:

- Remove very old MSYS2_ARG_CONV_EXCL workaround in bld.bat
- Remove very old IFS workaroundin build.sh
- Update Automake to 1.16 (in both meta.yaml and build.sh)
- Update aclocal include path given to autoreconf
- Remove `posix` dep; add`m2-{grep,m4}` (on Windows only, of course)
- Change `make` dep to `m2-make` (Windows only)
- Change `m2w64-pkg-config` dep to `m2-pkg-config` (Windows only)
- Switch to MSVC compilers: change `compiler('m2w64_c')` to `compiler('c')`, etc

And in this particular package, we need to patch the source to work on a
native MSVC build. I'm not sure that it 100% works but this package
isn't exactly mission-critical.
@pkgw pkgw merged commit 4fcff52 into conda-forge:main Feb 6, 2024
7 checks passed
@pkgw
Copy link
Contributor

pkgw commented Feb 6, 2024

I'll duplicate one of my commit messages here in the PR discussion. For posterity, here are the changes to update the package to work with the updated MSYS2 stack:

  • Remove very old MSYS2_ARG_CONV_EXCL workaround in bld.bat
  • Remove very old IFS workaround in build.sh
  • Update Automake to 1.16 (in both meta.yaml and build.sh)
  • Update aclocal include path given to autoreconf
  • Remove posix dep; addm2-{grep,m4} (on Windows only, of course)
  • Change make dep to m2-make (Windows only)
  • Change m2w64-pkg-config dep to m2-pkg-config (Windows only)
  • Switch to MSVC compilers: change compiler('m2w64_c') to compiler('c'), etc

Other X.org packages that are migrating should also use the opportunity to start depending on the unified xorg-xorgproto protocol package, which supersedes the individual xorg-*proto packages that we have used historically.

In this particular package, we also need to patch the source to work on a native MSVC build. I believe that most other X.org packages should be able to build with MSVC without needing (additional) patching.

@ehfd
Copy link
Member

ehfd commented May 8, 2024

In case there's an error preventing build in MS VC (I have seen a lot of blockers requiring dirty patches):

From isuruf: (the Windows GCC toolchain compatible with) m2-automake1.16 is still being worked on. Not there yet.

@ehfd
Copy link
Member

ehfd commented Jun 14, 2024

Switch to MSVC compilers: change compiler('m2w64_c') to compiler('c'), etc

https://anaconda.org/search?q=mingw-w64-ucrt-x86_64-gcc

It might be that this is the new mingw compiler which may be used for (many) feedstocks for X.org which do not run properly on VC.

@ehfd
Copy link
Member

ehfd commented Sep 20, 2024

I think this example is a good direction to go for X11 feedstocks.
conda-forge/xorg-libxcvt-feedstock#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants