-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xorg-makedepend v1.0.9 #9
Conversation
…nda-forge-pinning 2024.02.04.07.53.20
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Windows is hitting an error we've seen in more and more of these packages:
... but note that last month the M2 packages finally got updated after several years, so we have 2.71.3 as an option! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Current issue is a lack of (Side note, it looks like the |
Ah, yes, I believe that the idea is that the new version won't let you use the Cygwin/MinGW POSIX compatibility libraries; your code has to be compatible with the native Windows APIs without relying on the support libraries. In the particular case of |
For posterity, here are the changes: - Remove very old MSYS2_ARG_CONV_EXCL workaround in bld.bat - Remove very old IFS workaroundin build.sh - Update Automake to 1.16 (in both meta.yaml and build.sh) - Update aclocal include path given to autoreconf - Remove `posix` dep; add`m2-{grep,m4}` (on Windows only, of course) - Change `make` dep to `m2-make` (Windows only) - Change `m2w64-pkg-config` dep to `m2-pkg-config` (Windows only) - Switch to MSVC compilers: change `compiler('m2w64_c')` to `compiler('c')`, etc And in this particular package, we need to patch the source to work on a native MSVC build. I'm not sure that it 100% works but this package isn't exactly mission-critical.
…nda-forge-pinning 2024.02.06.11.02.25
I'll duplicate one of my commit messages here in the PR discussion. For posterity, here are the changes to update the package to work with the updated MSYS2 stack:
Other X.org packages that are migrating should also use the opportunity to start depending on the unified In this particular package, we also need to patch the source to work on a native MSVC build. I believe that most other X.org packages should be able to build with MSVC without needing (additional) patching. |
In case there's an error preventing build in MS VC (I have seen a lot of blockers requiring dirty patches): From isuruf: (the Windows GCC toolchain compatible with) m2-automake1.16 is still being worked on. Not there yet. |
https://anaconda.org/search?q=mingw-w64-ucrt-x86_64-gcc It might be that this is the new mingw compiler which may be used for (many) feedstocks for X.org which do not run properly on VC. |
I think this example is a good direction to go for X11 feedstocks. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7777930515, please use this URL for debugging.