Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Build against latest qt6-main #357

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

larsoner
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I know #354 is in progress, but in the meantime I think just ticking the build number and merging should fix incompatibility with the latest qt6-main, i.e. allow this to succeed:

$ conda create -n vtktest "vtk=9.3.1=*qt*" "qt6-main=6.8.1"
Channels:
 - conda-forge
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package vtk-base-9.3.1-qt_py312h1234567_200 requires qt6-main >=6.7.2,<6.8.0a0, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ qt6-main 6.8.1**  is installable with the potential options
│  ├─ qt6-main 6.8.1, which can be installed;
│  └─ qt6-main 6.8.1 would require
│     └─ libxcb >=1.16,<1.17.0a0 , which can be installed;
└─ vtk 9.3.1 *qt* is not installable because there are no viable options
   ├─ vtk 9.3.1 would require
   │  └─ vtk-base [9.3.1 qt_py310h1234567_200|9.3.1 qt_py310h2c847e9_204|...|9.3.1 qt_py39hff486e7_206], which requires
   │     └─ qt6-main >=6.7.2,<6.8.0a0 , which conflicts with any installable versions previously reported;
   └─ vtk 9.3.1 would require
      └─ vtk-base [9.3.1 qt_py310h9617cfe_209|9.3.1 qt_py311h7158b74_209|9.3.1 qt_py312hc73667e_209|9.3.1 qt_py313h576883f_209|9.3.1 qt_py39he1f0fb8_209], which requires
         ├─ libxcb >=1.17.0,<2.0a0 , which conflicts with any installable versions previously reported;
         └─ qt6-main >=6.7.3,<6.8.0a0 , which conflicts with any installable versions previously reported.

Even if 9.4 lands soon it would still be nice to have a 9.3.1 variant that works with newer Qt (e.g., for PyVista which now pins to <9.4 until they improve compat).

(FYI my motivation is that VTK is currently the only dependency holding me back from using PySide 6.8 in a standalone installer I'm creating.)

@larsoner
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Recipe maintainer "Maxyme" does not exist

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12375391990. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12375402853. Examine the logs at this URL for more detail.

@larsoner
Copy link
Contributor Author

Yikes hope these failures are just because GitHub is having a bad day. I'll request CI restart once things settle

@larsoner
Copy link
Contributor Author

@conda-forge-admin please restart ci

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12390668152. Examine the logs at this URL for more detail.

@larsoner
Copy link
Contributor Author

Well I'm mystified about the error, no real meaningful/informative traceback that I can find 😢

@Tobias-Fischer
Copy link
Contributor

CMake Error at CMake/vtkModule.cmake:4796 (message):
Could not find the LZMA external dependency.
Call Stack (most recent call first):
CMake/vtkModule.cmake:5396 (vtk_module_find_package)
CMake/vtkModule.cmake:5264 (vtk_module_third_party_external)
ThirdParty/lzma/CMakeLists.txt:1 (vtk_module_third_party)

@larsoner
Copy link
Contributor Author

Thanks @Tobias-Fischer ! Feel free to merge if you agree it's worth getting a rebuild against latest qt6-main 👍

@Tobias-Fischer Tobias-Fischer merged commit 786615e into conda-forge:main Dec 18, 2024
73 checks passed
@larsoner larsoner mentioned this pull request Dec 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants