Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build static archives #156

Closed
wants to merge 2 commits into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Feb 21, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Likely the CI error is the same thing we saw in OpenMPI ( conda-forge/openmpi-feedstock#142 (comment) ). Namely a conda-build bug ( conda/conda-build#5179 ). There is a fix ( conda/conda-build#5181 ) in the recent conda-build 24.1.2 release that was just packaged ( conda-forge/conda-build-feedstock#217 ). Though there are some obstacles to adopting that conda-build version ( conda-forge/openmpi-feedstock#142 (comment) ), which we will need to clear first

@xhochy
Copy link
Member Author

xhochy commented Feb 21, 2024

Thanks for the hint. Then I'll just snooze work on this for 2-3 days.

@xhochy xhochy mentioned this pull request Feb 21, 2024
5 tasks
@xhochy xhochy closed this Feb 21, 2024
@xhochy xhochy deleted the remove-static-archives branch February 21, 2024 06:22
@jakirkham
Copy link
Member

Yep. Trying to save you some time

Though if you are comfortable +1-ing any (or all) of these options, that would be helpful:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants