Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hmaarrfk as maintainer #9

Closed
wants to merge 4 commits into from
Closed

Conversation

hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender
cc: @isuruf

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

@isuruf
Copy link
Member

isuruf commented Jan 17, 2021

@hmaarrfk, can you send a PR to update the version? I don't think we want to merge this as is.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@hmaarrfk
Copy link
Contributor Author

Fernando, unfortunately my time today is rather limited.

Happy to let this hang around if you want me to.

Otherwise, i simply skipped all package generation to allow this to go through without generating a package.

@nehaljwani
Copy link
Member

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

number: 1000
skip: True # [not linux64]
script: python setup.py install --single-version-externally-managed --record=record.txt
number: 1001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this 1001 and not 0?

- cudnn # [cuda_compiler_version != "None"]
- libpng
- jpeg
- ffmpeg =4.2 # [not win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put the pin in CBC.yaml instead?

@@ -1,4 +1,4 @@
{% set version = "0.2.1" %}
{% set version = "1.7.1 " %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 0.8.2?

@h-vetinari
Copy link
Member

Just saw this PR, sorry, I overlooked it when opening #12. I think I'm a bit further there already though - the package builds and imports fine, just the test suite that I added to the test section is giving me some grief related to jpeg integration.

I'll send you an invite to collaborate on my fork @hmaarrfk, then you can push to #12 directly. There's still some open TODOs, see OP, but most of them can be tackled in follow-ups, IMO.

@h-vetinari h-vetinari mentioned this pull request Jan 28, 2021
@isuruf isuruf closed this in #12 Mar 9, 2021
@hmaarrfk
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants