-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hmaarrfk as maintainer #9
Conversation
@conda-forge-admin please rerender
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
@hmaarrfk, can you send a PR to update the version? I don't think we want to merge this as is. |
…da-forge-pinning 2021.01.15.19.38.06
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Fernando, unfortunately my time today is rather limited. Happy to let this hang around if you want me to. Otherwise, i simply skipped all package generation to allow this to go through without generating a package. |
Upstream feedstock for reference: https://github.com/pytorch/vision/blob/635406c3325e276ec8d0055d296094e113b44b20/packaging/torchvision/meta.yaml |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
number: 1000 | ||
skip: True # [not linux64] | ||
script: python setup.py install --single-version-externally-managed --record=record.txt | ||
number: 1001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this 1001 and not 0?
- cudnn # [cuda_compiler_version != "None"] | ||
- libpng | ||
- jpeg | ||
- ffmpeg =4.2 # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put the pin in CBC.yaml instead?
@@ -1,4 +1,4 @@ | |||
{% set version = "0.2.1" %} | |||
{% set version = "1.7.1 " %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 0.8.2?
Just saw this PR, sorry, I overlooked it when opening #12. I think I'm a bit further there already though - the package builds and imports fine, just the test suite that I added to the test section is giving me some grief related to I'll send you an invite to collaborate on my fork @hmaarrfk, then you can push to #12 directly. There's still some open TODOs, see OP, but most of them can be tackled in follow-ups, IMO. |
thanks! |
@conda-forge-admin please rerender
cc: @isuruf
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)