Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonsu: new recipe #8842

Merged
merged 1 commit into from
Jul 22, 2019
Merged

bonsu: new recipe #8842

merged 1 commit into from
Jul 22, 2019

Conversation

tschoonj
Copy link
Contributor

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bonsu) and found it was in an excellent condition.

@tschoonj tschoonj mentioned this pull request Jul 17, 2019
Closed
@tschoonj
Copy link
Contributor Author

Any thoughts how I can fix the problem on Linux? With yum requirements?

scopatz
scopatz reviewed Jul 17, 2019
View reviewed changes
recipes/bonsu/meta.yaml Outdated Show resolved Hide resolved
@scopatz
Copy link
Member

scopatz commented Jul 17, 2019

There are a bunch of CDTs for this package: https://anaconda.org/search?q=libXxf86vm

You'll probably need to add something to the yum requirements too

@tschoonj tschoonj force-pushed the bonsu branch 3 times, most recently from e8e450a to e8176f8 Compare July 18, 2019 07:54
@tschoonj
Copy link
Contributor Author

I fixed the Linux problem but the Windows one remains... Any thoughts?

@scopatz
Copy link
Member

scopatz commented Jul 18, 2019

windows doesn't have the fftw package available: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=51839&view=logs&jobId=240f1fee-52bc-5498-a14a-8361bde76ba0&taskId=23010c01-6a9d-5f94-9037-792618644b77&lineStart=158&lineEnd=159&colStart=1&colEnd=1

@tschoonj tschoonj force-pushed the bonsu branch 4 times, most recently from 367ed42 to 60c5226 Compare July 19, 2019 10:46
@tschoonj
Copy link
Contributor Author

Can I get some guidance with all this MPI stuff? I have tried following the official guidelines, but it doesn't seem to work...

@scopatz
Copy link
Member

scopatz commented Jul 19, 2019

CC @conda-forge/staged-recipes

beckermr
beckermr reviewed Jul 19, 2019
View reviewed changes
recipes/bonsu/meta.yaml
- vtk
- numpy
- {{ mpi }} # [mpi != 'nompi']
- fftw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it appears the docs don't have this fftw in the runtime env. Maybe remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually, add a selector (e.g., ffwt # [mpi == 'nompi']

beckermr
beckermr reviewed Jul 19, 2019
View reviewed changes
recipes/bonsu/meta.yaml
- vtk
- numpy
- {{ mpi }} # [mpi != 'nompi']
- fftw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure why this one should be there. I am wondering if this is a bug in the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you might add a selector like above here too.

@beckermr
Copy link
Member

Looking more closely this feels like a conda-build bug.

@isuruf
Copy link
Member

isuruf commented Jul 19, 2019

conda-build 3.18 series has this bug. conda/conda-build#3617

@beckermr
Copy link
Member

One of the envs on linux has only openmpi in it, but then the solver fails:

ValueError: Incompatible component merge:
  - 'mpi_mpich_*'
  - 'mpi_openmpi_*'

which is super weird.

@tschoonj
Copy link
Contributor Author

So since this is a bug in conda itself, would it be ok if I just dropped Windows support for now?

@xhochy
Copy link
Member

xhochy commented Jul 22, 2019

So since this is a bug in conda itself, would it be ok if I just dropped Windows support for now?

Yes, just drop Windows support here. You can get it back in the feedstock by temporarily pinning the conda-build version there. Feel free to ping me then when you have questions.

@tschoonj
Copy link
Contributor Author

Ok, everything went green now...

@beckermr beckermr merged commit 7030336 into conda-forge:master Jul 22, 2019
@tschoonj
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopatz scopatz scopatz left review comments

@beckermr beckermr beckermr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tschoonj @conda-forge-linter @scopatz @beckermr @isuruf @xhochy