Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geomeTRIC #6503

Merged
merged 5 commits into from
Aug 16, 2018
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions recipes/geometric/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{% set name = "geometric" %}
{% set version = "0.8.7" %}

# openssl sha256 filename
{% set sha256 = "91421168d7c04305230a30dbaa96ba61832e6ff3dad49b07c686f60a5667b862" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
fn: geomeTRIC-{{ version }}.tar.gz
url: https://github.com/leeping/geomeTRIC/archive/{{ version }}.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since package/name applies .lower(), you can probably use {% set name = "geomeTRIC" %}, then use the templating in source fields.

But more importantly, yes, give 0.8.8 a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8.8 seems to have fixed the issue and I made the suggested changes.

sha256: {{ sha256 }}

build:
noarch: python
number: 0
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


requirements:
build:
- python
- setuptools
- pip
run:
- numpy>=1.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space, numpy >=1.11, but you could also use pin_compatible() https://conda.io/docs/user-guide/tasks/build-packages/variants.html?highlight=pin_compatible#pinning-at-the-recipe-level

- python
- networkx
- six

test:
# Some package might need a `test/commands` key to check CLI.
# List all the packages/modules that `run_test.py` imports.
imports:
- pytest
- geometric
requires:
- pytest
commands:
- py.test --pyargs geometric

about:
home: http://github.com/leeping/geomeTRIC/
license: MIT
license_family: MIT
license_file: LICENSE
summary: 'Molecular geometry optimizer in the TRIC coordinate system.'

# description: |
# doc_url: http://simplejson.readthedocs.io/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comments

dev_url: http://github.com/leeping/geomeTRIC/

extra:
recipe-maintainers:
- leeping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeping, are you ok with being a maintainer?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you.

- dgasmith
- yudongqiu
Copy link
Member

@isuruf isuruf Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yudongqiu, are you ok with being a maintainer?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yudongqiu Please reply. (I saw a typo above)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.