Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jmol #5996

Merged
merged 4 commits into from
Jun 5, 2018
Merged

Add jmol #5996

merged 4 commits into from
Jun 5, 2018

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Jun 2, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jmol) and found it was in an excellent condition.

Jmol is a free, open source molecule viewer for students, educators, and
researchers in chemistry, biochemistry, physics, and materials science.
doc_url: http://jmol.sourceforge.net/#Learn%20to%20use%20Jmol
dev_url: https://github.com/BobHanson/Jmol-SwingJS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

development has moved to github but there has been no release on github yet.

@@ -0,0 +1,5 @@
set -ex
mkdir -p "$PREFIX/share/jmol"
unzip jsmol.zip -d "$PREFIX/share/jmol"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use outputs: to separate jsmol and jmol?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. What's the difference?

@@ -0,0 +1,41 @@
{% set name = "Jmol" %}
{% set version = "14.29" %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some function to strip the patchlevel?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saraedum
Copy link
Member Author

saraedum commented Jun 2, 2018

@saraedum
Copy link
Member Author

saraedum commented Jun 2, 2018

I tried this locally, and jmol launched the Jmol GUI with this recipe.

sha256: {{ sha256 }}

build:
noarch: python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another noarch: value? This isn't Python of course…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic

@isuruf isuruf force-pushed the jmol branch 2 times, most recently from fc2e914 to 3273253 Compare June 3, 2018 04:34
@isuruf isuruf merged commit d69aea2 into conda-forge:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants