-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jmol #5996
Add jmol #5996
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Jmol is a free, open source molecule viewer for students, educators, and | ||
researchers in chemistry, biochemistry, physics, and materials science. | ||
doc_url: http://jmol.sourceforge.net/#Learn%20to%20use%20Jmol | ||
dev_url: https://github.com/BobHanson/Jmol-SwingJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
development has moved to github but there has been no release on github yet.
@@ -0,0 +1,5 @@ | |||
set -ex | |||
mkdir -p "$PREFIX/share/jmol" | |||
unzip jsmol.zip -d "$PREFIX/share/jmol" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I use outputs:
to separate jsmol
and jmol
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. What's the difference?
recipes/jmol/meta.yaml
Outdated
@@ -0,0 +1,41 @@ | |||
{% set name = "Jmol" %} | |||
{% set version = "14.29" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some function to strip the patchlevel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isuruf: This is part of conda-forge/sagelib-feedstock#19 and conda-forge/sage-feedstock#2 |
I tried this locally, and |
recipes/jmol/meta.yaml
Outdated
sha256: {{ sha256 }} | ||
|
||
build: | ||
noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another noarch:
value? This isn't Python of course…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generic
fc2e914
to
3273253
Compare
No description provided.