Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for scipy-stubs #28397

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

lucascolley
Copy link
Member

@lucascolley lucascolley commented Nov 28, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/scipy-stubs/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: jorenham. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/scipy-stubs/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/scipy-stubs/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12075163607. Examine the logs at this URL for more detail.

@lucascolley
Copy link
Member Author

@jorenham if you could comment here as well :) (we'll have to wait for the optype PR to get merged first before this will work)

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/scipy-stubs/meta.yaml) and found it was in an excellent condition.

@jorenham
Copy link

jorenham commented Nov 28, 2024

all good!
see also jorenham/scipy-stubs#216 (comment)

@jorenham
Copy link

@lucascolley optype is available conda-forge now (🎉):
https://anaconda.org/conda-forge/optype

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@lucascolley lucascolley marked this pull request as ready for review November 29, 2024 14:01
@lucascolley
Copy link
Member Author

@jorenham we aren't supposed to be able to import scipy_stubs, right? If not, is there an equivalent basic test that the build has succeeded?

@jorenham
Copy link

@jorenham we aren't supposed to be able to import scipy_stubs, right? If not, is there an equivalent basic test that the build has succeeded?

There's nothing to import actually; it's all static stubs 🤔

@lucascolley
Copy link
Member Author

I suppose we could do poe typetest instead?

@jorenham
Copy link

jorenham commented Nov 29, 2024

I suppose we could do poe typetest instead?

There's a chance that might only work if scipy is also installed, which is currently an optional dependency 🤔...
But I guess we could give it a shot?

@jorenham
Copy link

jorenham commented Nov 29, 2024

I suppose we could do poe typetest instead?

But if scipy is available at that point, then we could also go for a more thorough poe stubtest, or even poe tox.

@lucascolley
Copy link
Member Author

I just removed the import test for now. Maybe we can add some stricter testing in the future, but for now maybe pip check will suffice.

@lucascolley
Copy link
Member Author

@conda-forge/help-python ready for review, thanks!

@synapticarbors synapticarbors merged commit 809a073 into conda-forge:main Nov 29, 2024
7 checks passed
@lucascolley lucascolley deleted the scipy-stubs branch November 29, 2024 22:25
@lucascolley
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants