Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connectome-workbench packages #27880

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Oct 14, 2024

The Connectome Workbench provides a wb_command CLI and a wb_view GUI. For the purposes of building compute environments, the wb_view is rarely needed and much larger, so this creates the packages:

  • connectome-workbench-cli - CLI only
  • connecome-workbench-gui - GUI only
  • connectome-workbench - metapackage that installs both CLI and GUI

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found some lint.

Here's what I've got...

For recipes/connectome-workbench/meta.yaml:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'test', 'outputs', 'about', 'extra'].

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/connectome-workbench/meta.yaml:

  • It looks like the 'connectome-workbench' output doesn't have any tests.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/connectome-workbench/meta.yaml:

  • It looks like the 'connectome-workbench' output doesn't have any tests.

@effigies
Copy link
Contributor Author

Giving up on Windows and Mac builds for now. This is valuable as a Linux-only package, and we can work toward OSX and Windows as convenient.

@effigies effigies marked this pull request as ready for review October 14, 2024 19:30
@effigies
Copy link
Contributor Author

@conda-forge/help-c-cpp This is ready for review.

I'm curious if you have any advice. We have a package that produces three files:

  • bin/wb_command (binary)
  • bin/wb_shortcuts (script)
  • bin/wb_view (binary)

The wb_command and wb_view binaries share much of the same code base, but wb_command is much smaller and useful without the wb_view GUI, so I want to make two packages. Is it possible to build once and just split? The best I was able to do was to disable parts of the build in each package, but there is a lot of duplicated compilation here.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/connectome-workbench/meta.yaml:
    • hints:
      • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found some lint.

Here's what I've got...

For recipes/connectome-workbench/meta.yaml:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@effigies
Copy link
Contributor Author

@conda-forge/help-c-cpp I figured out the single build, multi-package, so I think this is ready to go (pending checks).

@conda-forge/bioconda-recipes The bioconda recipe hasn't been updated in a long time. I assumed it was abandoned. Should I be trying to submit this over there instead?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found it was in an excellent condition.

@effigies
Copy link
Contributor Author

OSX failure seems to have been server-side. This PR disables mac builds for now.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 29, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11575248337.

@effigies effigies force-pushed the workbench branch 3 times, most recently from 4d443be to 0ebe8e7 Compare October 29, 2024 14:01
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/connectome-workbench/meta.yaml) and found it was in an excellent condition.

@effigies
Copy link
Contributor Author

@conda-forge/help-c-cpp This is ready for review.

There does not appear to be a way in bioconda to split the package, and I have gotten no response from the bioconda team about whether they are interested in updating their (currently blacklisted) package.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/connectome-workbench/meta.yaml:
    • hints:
      • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@effigies
Copy link
Contributor Author

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ocefpaf ocefpaf merged commit 36b1433 into conda-forge:main Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants