Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ixwebsocket #27748

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Add ixwebsocket #27748

merged 11 commits into from
Oct 7, 2024

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Oct 2, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

github-actions bot commented Oct 2, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ixwebsocket/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 2, 2024

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy
bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge-webservices/actions/runs/11143161405.

@zklaus
Copy link
Contributor Author

zklaus commented Oct 2, 2024

@conda-forge-admin, please lint

@zklaus
Copy link
Contributor Author

zklaus commented Oct 2, 2024

@conda-forge-admin, please lint

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ixwebsocket/meta.yaml) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented Oct 2, 2024

Ready for review, @conda-forge/help-c-cpp.

Copy link

github-actions bot commented Oct 2, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/ixwebsocket/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

@zklaus
Copy link
Contributor Author

zklaus commented Oct 2, 2024

I added @timkpaine to the maintainers at his request. @timkpaine, could you please confirm here that you are willing to be a maintainer? Thanks!

@timkpaine
Copy link
Member

Confirmed

Copy link

github-actions bot commented Oct 2, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@isuruf isuruf merged commit 4e3ae3d into conda-forge:main Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants