Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for ergocub-software #26175

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 28, 2024

ergocub-software are a set of C++ libraries and tools, models and configuration files to run and simulate the ergoCub humanoid robot.

The proposed recipe adds two different packages:

  • libergocub-software: This is the package that is meant to be used if the package is consumed as a C/C++ library, and linked to a downstream project. To do so, the package contains a run_exports section. This package name contains the lib prefix as requested in Add recipe for libmatio-cpp #19764 (review) for C/C++ libraries.
  • ergocub-software: This is the package is an empty package that depends on libergocub-software and that is meant to be used if the package is just used to its configuration files and models, so it does not contain any run_exports.

The feedstock is named ergocub-software to match the repo name and support different package outputs names in the future.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ergocub-software) and found some lint.

Here's what I've got...

For recipes/ergocub-software:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ergocub-software) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ergocub-software) and found some lint.

Here's what I've got...

For recipes/ergocub-software:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [49]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ergocub-software) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge/help-c-cpp @conda-forge/staged-recipes the PR is ready for review.

fyi @Nicogene @xela-95

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@xhochy xhochy merged commit 645785e into conda-forge:main Apr 29, 2024
5 checks passed
@traversaro traversaro deleted the patch-62 branch April 29, 2024 21:42
@traversaro
Copy link
Contributor Author

Thanks @xhochy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants