Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe sparc-x-api #24093

Merged
merged 14 commits into from
Oct 16, 2023
Merged

New recipe sparc-x-api #24093

merged 14 commits into from
Oct 16, 2023

Conversation

alchem0x2A
Copy link
Contributor

@alchem0x2A alchem0x2A commented Sep 28, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sparc-x-api) and found some lint.

Here's what I've got...

For recipes/sparc-x-api:

  • requirements: build: python>=3.8 must contain a space between the name and the pin, i.e. python >=3.8
  • requirements: build: ase>=3.22 must contain a space between the name and the pin, i.e. ase >=3.22
  • requirements: host: python>=3.8 must contain a space between the name and the pin, i.e. python >=3.8
  • requirements: host: ase>=3.22 must contain a space between the name and the pin, i.e. ase >=3.22
  • requirements: run: python>=3.8 must contain a space between the name and the pin, i.e. python >=3.8
  • requirements: run: ase>=3.22 must contain a space between the name and the pin, i.e. ase >=3.22
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sparc-x-api) and found it was in an excellent condition.

@alchem0x2A
Copy link
Contributor Author

alchem0x2A commented Sep 28, 2023

@conda-forge/staged-recipes @conda-forge/help-python, Ready for review!

@alchem0x2A
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-python please review & merge the PR once you have time, thx!

@alchem0x2A
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-python pinging again for review request. Thank you!

recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
recipes/sparc-x-api/meta.yaml Outdated Show resolved Hide resolved
@alchem0x2A
Copy link
Contributor Author

@ocefpaf the updated recipe now uses post-link scripts. Appreciate your feedback

entry_points:
- "sparc-ase = sparc.cli:main"

requirements:
host:
- python >=3.8
- ase >=3.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try just removing this first? B/c if that works you don't need the post link. Post links will require to remove noarch and that is not desirable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf Thx for the information! I released a new version of the package (sparc-x-api v1.0.1) to make it work without the dependencies in build phase. Appreciate your feedback.

entry_points:
- "sparc-ase = sparc.cli:main"

requirements:
host:
- python >=3.8
- pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do need pip here b/c we use it in the python pip install command above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf Sorry for that. I've updated the meta.yaml.

@ocefpaf ocefpaf merged commit 1f5a4ce into conda-forge:main Oct 16, 2023
4 checks passed
@alchem0x2A
Copy link
Contributor Author

thx! @ocefpaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants