-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe sparc-x-api #24093
New recipe sparc-x-api #24093
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sparc-x-api:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes @conda-forge/help-python, Ready for review! |
@conda-forge/staged-recipes @conda-forge/help-python please review & merge the PR once you have time, thx! |
@conda-forge/staged-recipes @conda-forge/help-python pinging again for review request. Thank you! |
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Filipe <[email protected]>
@ocefpaf the updated recipe now uses post-link scripts. Appreciate your feedback |
recipes/sparc-x-api/meta.yaml
Outdated
entry_points: | ||
- "sparc-ase = sparc.cli:main" | ||
|
||
requirements: | ||
host: | ||
- python >=3.8 | ||
- ase >=3.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try just removing this first? B/c if that works you don't need the post link. Post links will require to remove noarch and that is not desirable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf Thx for the information! I released a new version of the package (sparc-x-api v1.0.1) to make it work without the dependencies in build phase. Appreciate your feedback.
recipes/sparc-x-api/meta.yaml
Outdated
entry_points: | ||
- "sparc-ase = sparc.cli:main" | ||
|
||
requirements: | ||
host: | ||
- python >=3.8 | ||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do need pip
here b/c we use it in the python pip install command above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf Sorry for that. I've updated the meta.yaml.
thx! @ocefpaf |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).