Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added glue-qt package #23697

Merged
merged 8 commits into from
Aug 21, 2023
Merged

Added glue-qt package #23697

merged 8 commits into from
Aug 21, 2023

Conversation

astrofrog
Copy link
Contributor

@astrofrog astrofrog commented Aug 17, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/glue-qt) and found it was in an excellent condition.

@astrofrog
Copy link
Contributor Author

I am willing to be a maintainer of the package

@astrofrog
Copy link
Contributor Author

@conda-forge/help-python - this is ready for review!

Comment on lines 38 to 39
- importlib-resources >=1.3 # [py<39]
- importlib-metadata >=3.6 # [py<310]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have empty packages for these on modern Python. That way you can drop the selector and make this noarch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Actually I just realised I need to add in python.app as a dependency which is OS-X only so can't actually specify noarch - but I've removed the selectors here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@astrofrog astrofrog requested a review from ocefpaf August 18, 2023 12:17
recipes/glue-qt/meta.yaml Outdated Show resolved Hide resolved
recipes/glue-qt/meta.yaml Outdated Show resolved Hide resolved
recipes/glue-qt/meta.yaml Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/glue-qt) and found some lint.

Here's what I've got...

For recipes/glue-qt:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/glue-qt) and found some lint.

Here's what I've got...

For recipes/glue-qt:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@astrofrog
Copy link
Contributor Author

@ocefpaf - thanks for the suggestions! Is there documentation regarding the build strings and what they should be for this kind of situation? Also is the linter error safe to ignore about the selectors?

Co-authored-by: Filipe <[email protected]>
@astrofrog
Copy link
Contributor Author

Thanks for the remaining suggestion! I'll admit I don't quite understand the magic happening here for semi-noarch packages 😅

recipes/glue-qt/meta.yaml Outdated Show resolved Hide resolved
@ocefpaf
Copy link
Member

ocefpaf commented Aug 21, 2023

@ocefpaf - thanks for the suggestions! Is there documentation regarding the build strings and what they should be for this kind of situation?

Those are not in our docs, see https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-packages-with-os-specific-dependencies

To be honest this is kind of new and I'm still getting used to it. Maybe we no longer need those. See conda-forge/conda-forge.github.io#1839 (comment)

Also is the linter error safe to ignore about the selectors?

Yep. It is a bug and should be fixed by conda-forge/conda-smithy#1735

@astrofrog
Copy link
Contributor Author

@ocefpaf - I think this is ready now

@astrofrog astrofrog requested a review from ocefpaf August 21, 2023 14:10
@ocefpaf ocefpaf merged commit 9d57857 into conda-forge:main Aug 21, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants