-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added glue-qt package #23697
Added glue-qt package #23697
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I am willing to be a maintainer of the package |
@conda-forge/help-python - this is ready for review! |
recipes/glue-qt/meta.yaml
Outdated
- importlib-resources >=1.3 # [py<39] | ||
- importlib-metadata >=3.6 # [py<310] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have empty packages for these on modern Python. That way you can drop the selector and make this noarch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Actually I just realised I need to add in python.app as a dependency which is OS-X only so can't actually specify noarch - but I've removed the selectors here.
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Co-authored-by: Filipe <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/glue-qt:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/glue-qt:
|
@ocefpaf - thanks for the suggestions! Is there documentation regarding the build strings and what they should be for this kind of situation? Also is the linter error safe to ignore about the selectors? |
Co-authored-by: Filipe <[email protected]>
Thanks for the remaining suggestion! I'll admit I don't quite understand the magic happening here for semi-noarch packages 😅 |
Co-authored-by: Filipe <[email protected]>
Those are not in our docs, see https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-packages-with-os-specific-dependencies To be honest this is kind of new and I'm still getting used to it. Maybe we no longer need those. See conda-forge/conda-forge.github.io#1839 (comment)
Yep. It is a bug and should be fixed by conda-forge/conda-smithy#1735 |
@ocefpaf - I think this is ready now |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).