Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda metapackage recipes #23178

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Add cuda metapackage recipes #23178

merged 5 commits into from
Oct 10, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Jun 26, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

xref: #21382

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda, recipes/cuda-command-line-tools, recipes/cuda-toolkit, recipes/cuda-tools, recipes/cuda-visual-tools) and found it was in an excellent condition.

@adibbley adibbley mentioned this pull request Jun 26, 2023
49 tasks
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions like "why does cuda-nvml-dev not belong to cuda-libraries-dev?" and similarly for gds-tools not being a part of cuda-command-line-tools but I would guess that those questions are beyond the scope of conda-forge and are just part of the broader CUDA deployment decisions. This looks generally fine.

recipes/cuda/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-command-line-tools/meta.yaml Show resolved Hide resolved
recipes/cuda-toolkit/README.md Outdated Show resolved Hide resolved
recipes/cuda-command-line-tools/meta.yaml Show resolved Hide resolved
recipes/cuda-command-line-tools/meta.yaml Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks good here, just need to apply the maintainers list suggestion. Are there other action items needed before merging?

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM assuming that we apply the suggestion to the maintainers list.

One thing that might be helpful for future readers of the recipe is to note that for versions we use {{ version }} for metapackages and explicit version numbers for everything else. It's sort of hinted at by the current contents of the README, but it may be helpful to be more explicit.

@adibbley adibbley marked this pull request as ready for review October 10, 2023 20:25
@jakirkham jakirkham merged commit b85ed40 into conda-forge:main Oct 10, 2023
4 of 6 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else on the feedstock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants