Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nsight-compute recipe #23001

Merged
merged 15 commits into from
Jul 11, 2023
Merged

Add nsight-compute recipe #23001

merged 15 commits into from
Jul 11, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Jun 2, 2023

xref: #21382

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nsight-compute) and found it was in an excellent condition.

@adibbley adibbley mentioned this pull request Jun 2, 2023
49 tasks
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Had a couple questions below

recipes/nsight-compute/build.sh Outdated Show resolved Hide resolved
recipes/nsight-compute/meta.yaml Outdated Show resolved Hide resolved
recipes/nsight-compute/meta.yaml Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request for testing the executable, otherwise please apply @jakirkham's suggestions.

recipes/nsight-compute/meta.yaml Show resolved Hide resolved
@adibbley adibbley marked this pull request as ready for review June 14, 2023 22:57
Comment on lines +6 to +10
nsightVersion=$(echo $PKG_VERSION | cut -d. -f1-3)
nsightLib32="nsight-compute/${nsightVersion}/target/linux-desktop-glibc_2_11_3-x86/"

# Remove 32bit libraries
[[ -d "${nsightLib32}" ]] && rm -rf ${nsightLib32}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this could probably be generalized using something like

set +e
rm -rf nsight-compute/*/target/*x86
set -e

The set would only be needed if a nonzero exit code is problematic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO when it comes to removing things from the build I would rather keep this specific, so if something gets added we aren't removing it without knowing.

recipes/nsight-compute/meta.yaml Outdated Show resolved Hide resolved
recipes/nsight-compute/meta.yaml Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once open conversations are resolved.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Maybe we can try adding wrapper scripts to call the .exes (as below). This is a strategy we have used for similar situations in the past (though it is always possible the code below needs additional tweaks)

recipes/nsight-compute/bld.bat Show resolved Hide resolved
recipes/nsight-compute/bld.bat Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting dropping the missing_dso_whitelist portion since this may already be addressed by dependencies since added. Even if not, would be good if we can solve this with adding dependencies instead to gain some confidence that this will work in a user's environment

recipes/nsight-compute/meta.yaml Outdated Show resolved Hide resolved
recipes/nsight-compute/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Think we need to add these dependencies based on the linking errors in CI. Though we may need more. Will need to look at CI based on the results after adding these

recipes/nsight-compute/meta.yaml Outdated Show resolved Hide resolved
recipes/nsight-compute/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham merged commit d6b6664 into conda-forge:main Jul 11, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's get this one out. We can follow up on anything else in the feedstock 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants