Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cuda-sanitizer-api recipe #23000

Merged
merged 16 commits into from
Jun 23, 2023
Merged

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Jun 2, 2023

xref: #21382

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-sanitizer-api) and found it was in an excellent condition.

@adibbley adibbley mentioned this pull request Jun 2, 2023
49 tasks
@adibbley adibbley marked this pull request as ready for review June 13, 2023 21:56
@jakirkham jakirkham requested a review from bdice June 13, 2023 21:59
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Had a couple questions below

recipes/cuda-sanitizer-api/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-sanitizer-api/bld.bat Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but generally LGTM.

recipes/cuda-sanitizer-api/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small questions.

recipes/cuda-sanitizer-api/meta.yaml Show resolved Hide resolved
build:
- {{ compiler("c") }}
- {{ compiler("cxx") }}
- arm-variant * {{ arm_variant_type }} # [aarch64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my information, how does this constraint work? Is the * for "any version", and the arm_variant_type selecting a particular build? If so, should it be using the build string to select sbsa? I'm assuming that this is right and that it's revealing some gap in my knowledge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set the supported arm_variant_type in conda_build_config.yaml

John can probably explain better, but I would expect this to match any version including the build string

Copy link
Contributor

@vyasr vyasr Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham could you clarify here? I know that we're using the CBC here but I don't understand exactly what the constraint syntax is going to include/exclude in this case. In particular I want to verify that this is basically using the build string to filter sbsa. I think I'm mostly confused because I thought the build string component would need an equals sign, something like arm-variant=*={{arm_variant_type}} rather than just being space-separated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the syntax above works in meta.yaml. It is equivalent to = based syntax one would use when calling on the command line

recipes/cuda-sanitizer-api/meta.yaml Show resolved Hide resolved
recipes/cuda-sanitizer-api/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-sanitizer-api/meta.yaml Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have permissions to resolve threads here, but aside from one open question regarding build strings this looks good to me.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Maybe we can try adding wrapper scripts to call the .exes (as below). This is a strategy we have used for similar situations in the past (though it is always possible the code below needs additional tweaks)

recipes/cuda-sanitizer-api/bld.bat Show resolved Hide resolved
recipes/cuda-sanitizer-api/bld.bat Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Looks like the Windows build is erroring as part of building the package. Perhaps we can add a few lines to get more info about what is failing

recipes/cuda-sanitizer-api/bld.bat Show resolved Hide resolved
recipes/cuda-sanitizer-api/bld.bat Show resolved Hide resolved
recipes/cuda-sanitizer-api/bld.bat Show resolved Hide resolved
@jakirkham jakirkham merged commit 932a9ae into conda-forge:main Jun 23, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's get this in. We can follow up on anything else in the feedstock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants