-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gocommands package #22556
Adding gocommands package #22556
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gocommands:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gocommands:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cfb5052
to
c41feff
Compare
@conda-forge/staged-recipes, this package is read for review. |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please build the binaries from source instead of repackaging pre-built binaries.
https://conda-forge.org/docs/maintainer/knowledge_base.html#compilers
conda-forge/conda-forge.github.io#1052
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gocommands:
|
b6ca096
to
f776db4
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@xhochy @carterbox I reworked the recipe to build the binary from source. Can you review it again? |
I updated the branch, but it didn't fix the issue. |
Include the licenses of dependencies using "go-licenses". |
Skip building on Windows Co-authored-by: Uwe L. Korn <[email protected]>
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).