Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distopia package #20804

Merged
merged 40 commits into from
Nov 2, 2022
Merged

Add distopia package #20804

merged 40 commits into from
Nov 2, 2022

Conversation

hmacdope
Copy link
Contributor

@hmacdope hmacdope commented Oct 19, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found some lint.

Here's what I've got...

For recipes/distopia:

  • There are too few lines. There should be one empty line at the end of the file.
  • Recipe maintainer "orbecskt" does not exist

For recipes/distopia:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/distopia:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found some lint.

Here's what I've got...

For recipes/distopia:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]

For recipes/distopia:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@hmacdope
Copy link
Contributor Author

@orbeckst @richardjgowers are you okay being listed as maintainers?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/distopia:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@orbeckst
Copy link

Sure, no problem.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found it was in an excellent condition.

@richardjgowers
Copy link
Contributor

Yep that's fine!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found some lint.

Here's what I've got...

For recipes/distopia:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found some lint.

Here's what I've got...

For recipes/distopia:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found it was in an excellent condition.

@hmacdope
Copy link
Contributor Author

@conda-forge/help-python ready for review :)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/distopia) and found it was in an excellent condition.

@hmacdope
Copy link
Contributor Author

@conda-forge/help-python-c :)

recipes/distopia/meta.yaml Outdated Show resolved Hide resolved
recipes/distopia/meta.yaml Outdated Show resolved Hide resolved
recipes/distopia/meta.yaml Show resolved Hide resolved
recipes/distopia/meta.yaml Outdated Show resolved Hide resolved
@dopplershift
Copy link
Member

@hmacdope Please don't remove other recipes, that will mess up the mechanics. It should be fine to leave it.

@hmacdope
Copy link
Contributor Author

@hmacdope Please don't remove other recipes, that will mess up the mechanics. It should be fine to leave it.

Apologies I will revert

@hmacdope hmacdope requested a review from xhochy November 1, 2022 00:36
@xhochy xhochy merged commit 116df80 into conda-forge:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants