-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s5cmd. #18306
Merged
Merged
Add s5cmd. #18306
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9e8025f
Add s5cmd.
benjaminrwilson 387310d
Update recipe.
benjaminrwilson 43c6df3
Update recipe.
benjaminrwilson 08e0a4d
Update recipe.
benjaminrwilson 5fbc515
Add lib licenses.
benjaminrwilson 8e34bda
Update license.
benjaminrwilson d980a1a
Remove .go files.
benjaminrwilson b353b59
Remove additional files.
benjaminrwilson ff8efda
Remove yml.
benjaminrwilson 191568c
Update meta.yaml
benjaminrwilson a002aae
Add licenses.
benjaminrwilson 476ef43
Update meta.yaml
benjaminrwilson b01199c
Update meta.yaml
benjaminrwilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| {% set name = "s5cmd" %} | ||
| {% set version = "1.4.0" %} | ||
|
|
||
| package: | ||
| name: {{ name|lower }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://github.com/peak/s5cmd/archive/refs/tags/v{{ version }}.tar.gz | ||
| sha256: b756ac8c69175d04e972c3b4deb6b689986d4260fbe83e32caea52d1061995a0 | ||
|
|
||
| build: | ||
| script: go install -v . | ||
| number: 0 | ||
|
|
||
| requirements: | ||
| build: | ||
| - {{ compiler('go') }} | ||
|
|
||
| test: | ||
| commands: | ||
| - s5cmd --help | ||
|
|
||
| about: | ||
| home: https://github.com/peak/{{ name }} | ||
| summary: 's5cmd is a very fast S3 and local filesystem execution tool.' | ||
| description: | | ||
| s5cmd is a very fast S3 and local filesystem execution tool. | ||
| It comes with support for a multitude of operations including tab completion and wildcard support for files, | ||
| which can be very handy for your object storage workflow while working with large number of files. | ||
| license: MIT | ||
| license_family: MIT | ||
| license_file: LICENSE | ||
BastianZim marked this conversation as resolved.
Show resolved
Hide resolved
BastianZim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| doc_url: https://github.com/peak/{{ name }} | ||
| dev_url: https://github.com/peak/{{ name }} | ||
BastianZim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - benjaminrwilson | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a blocker but it would be good to hardcode this instead of using a variable. Sometimes the bot gets tripped up on those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look, @BastianZim --- it's very appreciated!
That's correct.
Will push a fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great! Would you recommend it for other packages as well? I'd add it to the docs then because the go licensing is an ongoing discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it went pretty smoothly. It required some manual effort of cleaning out the exported data (some lingering files unrelated to the actual license/notice files), but it's definitely much better than manually searching for everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's good to know because for rust we have a tool that just does this during build so we might be able to do it here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, variables are for things that change. We, hope, that the name of a package doesn't change :-). Using the package name instead of a variable makes the recipe more readable and easier to type too. Thanks for changing it!