Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add towhee #17359

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Add towhee #17359

merged 1 commit into from
Dec 30, 2021

Conversation

haorenfsa
Copy link
Contributor

@haorenfsa haorenfsa commented Dec 27, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/towhee) and found some lint.

Here's what I've got...

For recipes/towhee:

  • The recipe license should not include the word "License".

For recipes/towhee:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/towhee) and found it was in an excellent condition.

@haorenfsa
Copy link
Contributor Author

Waiting for issue: conda-forge/pytorch-cpu-feedstock#32 to be solved

@haorenfsa haorenfsa changed the title Add towhee WIP: Add towhee Dec 27, 2021
@BastianZim
Copy link
Member

BastianZim commented Dec 27, 2021

Waiting for issue: conda-forge/pytorch-cpu-feedstock#32 to be solved

This is most likely going to take some time so I wouldn't wait for it. If your package is otherwise working and noarch it's perfectly fine if one OS fails due to missing dependencies. Once merged, your package will only be built on Linux but available on every platform (Where the dependencies are available) so Windows here is not important.

recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/towhee) and found some lint.

Here's what I've got...

For recipes/towhee:

  • requirements: run: pytorch>=1.4.0 must contain a space between the name and the pin, i.e. pytorch >=1.4.0
  • requirements: run: torchvision>=0.4.0 must contain a space between the name and the pin, i.e. torchvision >=0.4.0
  • requirements: run: numpy>=1.19.5 must contain a space between the name and the pin, i.e. numpy >=1.19.5
  • requirements: run: pandas>=1.1.5 must contain a space between the name and the pin, i.e. pandas >=1.1.5
  • requirements: run: pillow>=8.3.1 must contain a space between the name and the pin, i.e. pillow >=8.3.1
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/towhee) and found some lint.

Here's what I've got...

For recipes/towhee:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/towhee) and found it was in an excellent condition.

@haorenfsa haorenfsa changed the title WIP: Add towhee Add towhee Dec 28, 2021
@haorenfsa haorenfsa changed the title Add towhee WIP: Add towhee Dec 28, 2021
@haorenfsa haorenfsa changed the title WIP: Add towhee Add towhee Dec 28, 2021
recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
@haorenfsa
Copy link
Contributor Author

@BastianZim Changes are done according to your suggestion.

recipes/towhee/meta.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants