Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package tensorflow_addons #16888
base: main
Are you sure you want to change the base?
package tensorflow_addons #16888
Changes from 12 commits
f74fe06
732f982
21874b8
fe7d8a9
f01a5b8
2e0b6dd
84c72c5
96a5d0e
3a8b268
382a68c
c7fecf9
61393ef
57ac135
dd1cc0a
bda1641
b231cee
f5b321d
7d9971c
eef2643
e45d163
e2f2cdb
397aed9
c2267f7
0e2a861
091f7da
27a8c2f
f9f053d
932cd39
bac4b0f
03d7ac2
3450cb4
3099efc
7e4d10c
cb05888
2a63b82
160677d
1115e66
d1582f3
aa82c3e
96e4faf
c092c02
62ea10b
03d89a5
271f800
3ca86d2
51179cb
edc4390
4ead1fe
5549d4a
fa03456
9ae7a50
ddcd0fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the
bazel-toolchain
here? CUDA changes have been merged and applied forjaxlib
, so this should be good to go here, too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "add" mean? I changed
bazel
tobazel-toolchain
, but that didn't work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I don't understand this - it's already there as a host req, so why does it also need to be in run? - but without this we get:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libtensorflow_cc
doesn't have arun_exports
, we should add one there.