Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package tensorflow_addons #16888

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
f74fe06
add tensorflow_addons
h-vetinari Nov 10, 2021
732f982
harmonize tf-versions due to lack of ABI
h-vetinari Nov 11, 2021
21874b8
make up for missing tf-cpu on osx
h-vetinari Nov 10, 2021
fe7d8a9
Direct maintainership to team of tensorflow-feedstock
h-vetinari Nov 10, 2021
f01a5b8
switch to bazel-toolchain
h-vetinari Nov 10, 2021
2e0b6dd
change compute capabilities to format used by tf-addons
h-vetinari Nov 10, 2021
84c72c5
add GCC_HOST_COMPILER_PATH
h-vetinari Nov 10, 2021
96a5d0e
adapt output of configure.py with sed
h-vetinari Nov 10, 2021
3a8b268
use libtf_cc
h-vetinari Nov 11, 2021
382a68c
add rsync
h-vetinari Nov 11, 2021
c7fecf9
add libtensorflow_cc as run-req
h-vetinari Nov 11, 2021
61393ef
centralize tf-version used in recipe
h-vetinari Nov 11, 2021
57ac135
Revert "make up for missing tf-cpu on osx"
h-vetinari Nov 11, 2021
dd1cc0a
add typeguard as run-req
h-vetinari Nov 11, 2021
bda1641
pass through test folder
h-vetinari Nov 11, 2021
b231cee
more tests
h-vetinari Nov 11, 2021
f5b321d
run only one test module
h-vetinari Nov 11, 2021
7d9971c
add conftest.py
h-vetinari Nov 11, 2021
eef2643
go back to full test suite
h-vetinari Nov 11, 2021
e45d163
remove run_all_test.py files that break collection
h-vetinari Nov 11, 2021
e2f2cdb
use double asterisk & set globstar option
h-vetinari Nov 12, 2021
397aed9
also remove tests/__init__.py
h-vetinari Nov 12, 2021
c2267f7
add missing test dependencies
h-vetinari Nov 12, 2021
0e2a861
try with only __init__.py removal
h-vetinari Nov 12, 2021
091f7da
readd run_all_test removal
h-vetinari Nov 12, 2021
27a8c2f
add patches for remaining test issues
h-vetinari Nov 12, 2021
f9f053d
conda build cannot handle rename-only patch
h-vetinari Nov 12, 2021
932cd39
clean up comments & context for test suite modifications
h-vetinari Nov 12, 2021
bac4b0f
sklearn before tf, pretty please?
h-vetinari Nov 12, 2021
03d7ac2
exploratory patch for pytest_addoption usage
h-vetinari Nov 12, 2021
3450cb4
add tqdm to test-reqs
h-vetinari Nov 12, 2021
3099efc
add patch to find test images outside of source tree
h-vetinari Nov 12, 2021
7e4d10c
modify comment
h-vetinari Nov 12, 2021
cb05888
add cbc for GCC 7
h-vetinari Nov 14, 2021
2a63b82
try GPU-build again with libtensorflow
h-vetinari Nov 14, 2021
160677d
use bazel-toolchain to build package
h-vetinari Nov 16, 2021
1115e66
Update recipes/tensorflow-addons/build.sh
h-vetinari Nov 20, 2021
d1582f3
call gen-bazel-toolchain
h-vetinari Nov 23, 2021
aa82c3e
put options after bazel build
h-vetinari Nov 25, 2021
96e4faf
remove --target_cpu
h-vetinari Nov 26, 2021
c092c02
reduce cbc.yaml
h-vetinari Nov 26, 2021
62ea10b
move to centos 7
h-vetinari Nov 26, 2021
03d89a5
skip osx
h-vetinari Nov 26, 2021
271f800
pin cuda build also for libraries
h-vetinari Nov 26, 2021
3ca86d2
you're not getting away this time
h-vetinari Nov 26, 2021
51179cb
use protobuf 3.18
h-vetinari Nov 26, 2021
edc4390
use tensorflow-base in host
h-vetinari Nov 26, 2021
4ead1fe
try again with libtensorflow
h-vetinari Nov 26, 2021
5549d4a
simplify dependencies again
h-vetinari Nov 29, 2021
fa03456
pass extra header directory to bazel build
h-vetinari Nov 29, 2021
9ae7a50
Merge remote-tracking branch 'upstream/main' into tf-addons
h-vetinari Jul 31, 2022
ddcd0fd
Update recipes/tensorflow-addons/build.sh
h-vetinari Feb 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 203 additions & 0 deletions recipes/tensorflow-addons/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,203 @@
Copyright 2018 The TensorFlow Authors. All rights reserved.

Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
54 changes: 54 additions & 0 deletions recipes/tensorflow-addons/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
#!/bin/bash

set -ex

export PATH="$PWD:$PATH"
export CC=$(basename $CC)
export CXX=$(basename $CXX)
export LIBDIR=$PREFIX/lib
export INCLUDEDIR=$PREFIX/include

export TF_NEED_CUDA=0

if [[ ${cuda_compiler_version} != "None" ]]; then
export TF_NEED_CUDA=1
export TF_CUDA_PATHS="${PREFIX},${CUDA_HOME}"
export TF_CUDA_VERSION="${cuda_compiler_version}"
export TF_CUDNN_VERSION="${cudnn}"
export GCC_HOST_COMPILER_PATH="${GCC}"
export CUDA_TOOLKIT_PATH="${CUDA_HOME}"
export CUDNN_INSTALL_PATH="${PREFIX}"

# addons uses a different nomenclature for compute capabilities than tf proper, see
# https://github.com/tensorflow/addons/blob/v0.14.0/build_deps/toolchains/gpu/cuda_configure.bzl#L18-L19
if [[ ${cuda_compiler_version} == 10.* ]]; then
export TF_CUDA_COMPUTE_CAPABILITIES=3.5,5.0,6.0,6.2,7.0,7.2,7.5
elif [[ ${cuda_compiler_version} == 11.0* ]]; then
export TF_CUDA_COMPUTE_CAPABILITIES=3.5,5.0,6.0,6.2,7.0,7.2,7.5,8.0
elif [[ ${cuda_compiler_version} == 11.1 ]]; then
export TF_CUDA_COMPUTE_CAPABILITIES=3.5,5.0,6.0,6.2,7.0,7.2,7.5,8.0,8.6
elif [[ ${cuda_compiler_version} == 11.2 ]]; then
export TF_CUDA_COMPUTE_CAPABILITIES=3.5,5.0,6.0,6.2,7.0,7.2,7.5,8.0,8.6
else
echo "unsupported cuda version."
exit 1
fi
fi

# This script links project with TensorFlow dependency; creates .bazelrc
python ./configure.py
# ironically, configure.py cannot be configured, so sed it is...
sed -i'' -e "s:TF_HEADER_DIR=.*:TF_HEADER_DIR=\"$PREFIX/include\":" \
-e "s:TF_SHARED_LIBRARY_DIR=.*:TF_SHARED_LIBRARY_DIR=\"$PREFIX/lib\":" \
.bazelrc
# show result (& sleep to allow log to catch up)
h-vetinari marked this conversation as resolved.
Show resolved Hide resolved
cat .bazelrc
sleep 2

bazel build build_pip_pkg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the bazel-toolchain here? CUDA changes have been merged and applied for jaxlib, so this should be good to go here, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the bazel-toolchain here?

What does "add" mean? I changed bazel to bazel-toolchain, but that didn't work.


# build a whl file
mkdir -p $SRC_DIR/tf_addons_pkg
bash -x bazel-bin/build_pip_pkg $SRC_DIR/tf_addons_pkg

pip install tf_addons_pkg/tensorflow_addons-*.whl
65 changes: 65 additions & 0 deletions recipes/tensorflow-addons/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{% set version = "0.14.0" %}
{% set tf_version_maj_min = "2.6" %}

package:
name: tensorflow-addons
version: {{ version }}

source:
url: https://github.com/tensorflow/addons/archive/refs/tags/v{{ version }}.tar.gz
sha256: da9eaf683192054db73941e0de34d83754be4054dc92c409bc4693c3f3091586

build:
number: 0
# missing dependency: https://github.com/conda-forge/tensorflow-feedstock/issues/124
skip: true # [win]

requirements:
build:
- {{ compiler('cxx') }}
- {{ compiler('cuda') }} # [cuda_compiler_version != "None"]
- bazel
- bazel-toolchain
- rsync
- sed
host:
# GPU requirements for CUDA
- cudnn # [cuda_compiler_version != "None"]
- python
- pip
- libprotobuf
# check tensorflow-range per addons-version, see
# https://github.com/tensorflow/addons#python-op-compatibility-matrix
- tensorflow {{ tf_version_maj_min }}.*
# needed for headers in tensorflow/core/framework
- libtensorflow_cc {{ tf_version_maj_min }}.*
- tensorflow =*=cpu* # [cuda_compiler_version == "None"]
- tensorflow =*=cuda* # [cuda_compiler_version != "None"]
- typeguard >=2.7
run:
- python
# due to lack of ABI, we need the same version at runtime, see
# https://github.com/tensorflow/addons#c-custom-op-compatibility-matrix
- tensorflow {{ tf_version_maj_min }}.*
- libtensorflow_cc {{ tf_version_maj_min }}.*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't understand this - it's already there as a host req, so why does it also need to be in run? - but without this we get:

  ERROR (tensorflow-addons,lib/[something].so): Needed DSO lib/libtensorflow_framework.so.2 found in ['libtensorflow_cc']
  ERROR (tensorflow-addons,lib/[something].so): .. but ['libtensorflow_cc'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libtensorflow_cc doesn't have a run_exports, we should add one there.

- tensorflow =*=cpu* # [cuda_compiler_version == "None"]
- tensorflow =*=cuda* # [cuda_compiler_version != "None"]

test:
requires:
- pytest
imports:
- tensorflow_addons
commands:
- pytest -v

about:
home: https://github.com/tensorflow/addons
license: Apache-2.0
license_file: LICENSE
summary: Useful extra functionality for TensorFlow 2.x maintained by SIG-addons
dev_url: https://github.com/tensorflow/addons

extra:
recipe-maintainers:
- conda-forge/tensorflow