-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packages: libscenario
scenariopy
scenario
gym-ignition
#16582
Add packages: libscenario
scenariopy
scenario
gym-ignition
#16582
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
405cceb
to
e6118d2
Compare
I'm getting the following errors, @traversaro do you have some idea about the root of the DSO failing checks? Two questions, should I list other error
|
I guess adding all the required ignition libraries as host dependencies is probably. If they are |
c82e7d5
to
aabe0b4
Compare
aabe0b4
to
ff2ce4e
Compare
Exporting manually the dependencies fixed the problem (ff2ce4e). Just checking since it's not 100% clear, we do not build different ignition gazebo versions against multiple protobuf versions right? If I understood how it works, the default protobuf pinning should be this one right? |
82ebdae
to
073ec99
Compare
Exactly, this is correct. Then during protobuf migrations, it may happen that a build against a new protobuf is done before the pinning is updated (see https://conda-forge.org/status/#libprotobuf318 for example). |
libscenario
scenariopy
scenario
gym-ignition
073ec99
to
d6fe022
Compare
d6fe022
to
e535056
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gym-ignition:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ImportError: libGL.so.1: cannot open shared object file: No such file or directory
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gym-ignition:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
For the moment, my priority is starting to distribute the linux version of these packages. I'll keep iterating on the other platforms from the feedstock repository. In any case, Ignition Gazebo installed from conda-forge still has problems on both osx and windows. I'll proceed with a upstream new minor release (robotology-legacy/gym-ignition#411) including robotology-legacy/gym-ignition#406 and then mark this PR as ready to be merged. |
This reverts commit 0879cbc.
I'm not an expert on this, but it seems to me that CI of staged-recipes is different than CI of a feedstock, particularly because the latter is rendered and independent pipelines are generated. What I think I'm experiencing here is a collision between the package name and a subpackage name. Probably having a subpackage with the same package name confuses the CI of staged-recipes, but it seems a valid configuration (e.g. bullet-feedstock). If this is true, I'll disable the gym-ignition subpackage so that the feedstock gets created with the right name. Then, from the feedstock, I enable back the gym-ignition subpackage and rerender the recipe with a new build number. |
It will be enabled back from the resulting feedstock repository
@conda-forge/staged-recipes I've experienced some problems as described in #16582 (comment) but I hope I can fix them directly from the feedstock repo. Currently, linux builds work fine and this is a promising starting point. If you don't have anything to add here about the package / subpackage naming problem, this PR is ready for review. |
Hi @diegoferigo @traversaro sorry that this might have slipped under the radar. Should we pick it up again? |
Hi @wolfv, thanks for the ping. I've been caught up on something else recently and I had not enough time to solve the last upstream problems. I think that the linux recipe was working fine and I was waiting to do a upstream release, but then some problems have occurred (Ignition broke our way of updating the GUI) and I am waiting to fix them before tagging a new release. I'll ping you again as soon as I manage to finalize this PR, thanks! |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).