Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torchsparse. #15095

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Add torchsparse. #15095

merged 3 commits into from
Jun 6, 2021

Conversation

benjaminrwilson
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/torchsparse) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/torchsparse) and found some lint.

Here's what I've got...

For recipes/torchsparse:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/torchsparse) and found some lint.

Here's what I've got...

For recipes/torchsparse:

  • requirements: build: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7
  • requirements: host: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7
  • requirements: run: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/torchsparse) and found some lint.

Here's what I've got...

For recipes/torchsparse:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/torchsparse) and found it was in an excellent condition.

@benjaminrwilson
Copy link
Contributor Author

@chrisburr -- have you seen this build error before?

The build appears to be running out of space.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/torchsparse) and found it was in an excellent condition.

@benjaminrwilson
Copy link
Contributor Author

@conda-forge/staged-recipes , this is failing with No space left on device. Any ideas?

@ocefpaf
Copy link
Member

ocefpaf commented Jun 5, 2021

@conda-forge-admin, please restart ci

@chrisburr
Copy link
Member

The easiest solution is probably to disable GPU builds for now and re-enable them in the feedstock (the feedstock CI runs one-job per python version).

@benjaminrwilson
Copy link
Contributor Author

benjaminrwilson commented Jun 6, 2021

@chrisburr, I think this should be good to go now.

@chrisburr chrisburr merged commit 0f87207 into conda-forge:master Jun 6, 2021
@CCInc
Copy link
Contributor

CCInc commented Jul 8, 2021

Hi @benjaminrwilson , I'm one of the maintainers of torchsparse, awesome work! Would love to get your feedback on how to maintain this going forward, if you could drop us a note in mit-han-lab/torchsparse#93 or shoot me an email that'd be great!

@benjaminrwilson benjaminrwilson deleted the torchsparse branch July 9, 2021 11:38
@benjaminrwilson
Copy link
Contributor Author

Hi @CCInc,

Thanks! Would you mind putting up a small ticket for discussion here: https://github.com/conda-forge/torchsparse-feedstock/issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants