adding tilt-dev/tilt recipe #11935

joseph-zhong · 2020-06-16T21:35:54Z

Hi, this is my first time submitting a recipe PR! Thanks to everyone, the process was relatively smooth getting here.

One confusing part in the documentation is the expected behavior for using the newer MacOS SDK: in https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks it specifies to edit the recipe/conda_build_config.yaml, which in this case I'm assuming should be tilt/conda_build_config.yaml, and the former is after the PR is merged and the recipe is uploaded. I've tested the result of rerendering by locally running

conda-smithy rerender

and verifies the generated .ci_support/os64.yaml generates as expected

@conda-forge-admin, please ping team

Checklist

Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
License file is packaged (see here for an example)
Source is from official source
Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
If static libraries are linked in, the license of the static library is packaged.
Build number is 0
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

conda-forge-linter · 2020-06-16T21:35:56Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter · 2020-06-16T21:36:08Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tilt) and found some lint.

Here's what I've got...

For recipes/tilt:

The recipe must have a build/number section.

conda-forge-linter · 2020-06-16T21:37:55Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tilt) and found it was in an excellent condition.

conda-forge-linter · 2020-06-16T21:46:52Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter · 2020-06-16T21:47:43Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter · 2020-06-16T22:02:08Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter · 2020-06-16T22:02:50Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter · 2020-06-17T14:10:48Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

isuruf · 2020-06-23T18:36:12Z

Can you build from source?

joseph-zhong · 2020-06-23T19:14:20Z

Hey @isuruf thanks for taking a look -- Are there particular advantages from that as opposed to using the release binaries? It's likely possible, but the current setup is just emulating the recommended installation currently from https://github.com/tilt-dev/tilt/

@nicks do you have an opinion here?

isuruf · 2020-06-23T19:22:11Z

Yes, because we don't where the binaries come from. Particularly it looks it is using some go modules and is violating the licenses of those go modules because the pre built binary is not distributing the copyright notices and license texts of its dependencies.

joseph-zhong · 2020-06-23T19:36:55Z

@isuruf Got it -- that makes sense to me, I can look into compiling from source and get back to you on this, thanks again for the quick feedback

nicks · 2020-06-23T20:08:18Z

sgtm, i agree compiling from scratch is more the norm here.

@joseph-zhong Tilt uses goreleaser to compile the binaries, so the flags you need will look like this:
VERSION=... DATE=... COMMIT=... && go install -tags=osusergo -mod=vendor -ldflags="-s -w -X main.version=0.15.1 -X main.commit=$COMMIT -X main.date=$DATE" ./cmd/tilt

joseph-zhong · 2020-06-24T23:15:40Z

Thanks @nicks -- I was able to compile from source locally on both Win/UNIX, however it doesn't look like go v1.14 is available yet and I'm failing with the following dependency error, it appears we may have to wait for conda-forge/go-feedstock#87

@isuruf Do you have any suggestions otherwise if a dependency is not ready in conda-forge? Is there a way to install go 1.14 from the official source? It appears that's the only build requirement for compilation for both UNIX/Windows.

$ conda-build tilt
  File "C:\Users\josephz\Miniconda3\lib\site-packages\conda\resolve.py", line 288, in verify_specs
    raise ResolvePackageNotFound(bad_deps)
conda.exceptions.ResolvePackageNotFound:
  - go_win-64=1.14

nicks · 2020-07-22T23:41:37Z

@joseph-zhong can you try building the latest version of Tilt with go v1.13? I tried it out and I think it should work now.

joseph-zhong · 2020-07-23T14:18:09Z

Awesome @nicks! I'll try again and update the PR

conda-forge-linter · 2020-07-23T16:02:57Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tilt) and found some lint.

Here's what I've got...

For recipes/tilt:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [20]

conda-forge-linter · 2020-07-23T16:03:42Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tilt) and found it was in an excellent condition.

joseph-zhong · 2020-07-23T19:47:29Z

@conda-forge-admin, please rerender

conda-forge-linter · 2020-07-23T19:58:30Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/tilt) and found it was in an excellent condition.

conda-forge-linter · 2020-07-23T20:01:39Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tilt) and found it was in an excellent condition.

conda-forge-linter · 2020-07-23T20:06:18Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

chrisburr · 2020-07-24T14:01:24Z

.ci_support/osx64.yaml

-  - clangxx
-fortran_compiler:
-  - gfortran
+MACOSX_DEPLOYMENT_TARGET:


Can you revert the changes to this file (after addressing any other comments so we still see it's green). The CI will fail but I'll merge regardless (the recipes/tilt/conda_build_config.yaml will make sure the feedstock is correct).

recipes/tilt/meta.yaml

chrisburr · 2020-07-24T14:08:18Z

recipes/tilt/meta.yaml

+  home: https://github.com/tilt-dev/tilt
+  license: Apache-2.0
+  license_family: Apache
+  license_file: LICENSE


See conda-forge/conda-forge.github.io#1052 in particular for go: conda-forge/conda-forge.github.io#1052 (comment)

chrisburr · 2020-07-24T22:12:16Z

It should have been cxx instead of c++

joseph-zhong · 2020-07-28T19:28:33Z

Thanks @mariusvniekerk and @chrisburr for the comments! I've made sure the build is green for all OSes before reverting changes in .ci_support and made sure to run go-licenses to include the licenses for the dependency packages (I wasn't sure if I should include the licenses in this PR), please let me know if there are any other changes needed!

# This is the 1st commit message: address comments # The commit message conda-forge#2 will be skipped: # try c++ # The commit message conda-forge#3 will be skipped: # back to clang for osx # The commit message conda-forge#4 will be skipped: # cxx typo

joseph-zhong added 3 commits June 16, 2020 10:35

add tilt-dev/tilt distribution

73663c1

wip

a2f07d3

[tilt recipe] add windows install support

9c72c30

[tilt recipe] add build/number

cc36953

joseph-zhong mentioned this pull request Jun 16, 2020

distribute tilt with conda-forge tilt-dev/tilt#3431

Closed

[tilt] compile from source

c21ee8f

joseph-zhong marked this pull request as draft June 24, 2020 23:10

unify compile workflow for both UNIX/win, needs go=1.14

de102e8

joseph-zhong added 2 commits July 23, 2020 11:02

go=1.13 for latest 0.16.1 tilt

fa19305

clang needed for osx

f537181

lint

12c725e

add cgo enabled envvar

434c5b6

joseph-zhong added 4 commits July 23, 2020 12:33

wip

b835715

wip

be19b41

wip

9b2e4be

add run_constrained

f9170bd

prep for rerender

73a3f4b

joseph-zhong force-pushed the tilt-recipe branch from fc8dd43 to 73a3f4b Compare July 23, 2020 20:01

joseph-zhong marked this pull request as ready for review July 23, 2020 20:10

chrisburr reviewed Jul 24, 2020

View reviewed changes

joseph-zhong added 4 commits July 28, 2020 15:42

address comments

949bbac

prefix

b18749d

revert changes to .ci_support as requested

6e3bd29

joseph-zhong force-pushed the tilt-recipe branch from 9131266 to 6e3bd29 Compare July 28, 2020 19:42

mariusvniekerk merged commit e3a5edf into conda-forge:master Jul 28, 2020

joseph-zhong deleted the tilt-recipe branch July 29, 2020 02:46

joseph-zhong mentioned this pull request Jul 29, 2020

fix typo in build script conda-forge/tilt-feedstock#1

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding tilt-dev/tilt recipe #11935

adding tilt-dev/tilt recipe #11935

joseph-zhong commented Jun 16, 2020 •

edited

Loading

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 17, 2020

isuruf commented Jun 23, 2020

joseph-zhong commented Jun 23, 2020

isuruf commented Jun 23, 2020

joseph-zhong commented Jun 23, 2020

nicks commented Jun 23, 2020

joseph-zhong commented Jun 24, 2020 •

edited

Loading

nicks commented Jul 22, 2020

joseph-zhong commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

joseph-zhong commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

chrisburr Jul 24, 2020

chrisburr Jul 24, 2020

chrisburr commented Jul 24, 2020

joseph-zhong commented Jul 28, 2020 •

edited

Loading

adding tilt-dev/tilt recipe #11935

adding tilt-dev/tilt recipe #11935

Conversation

joseph-zhong commented Jun 16, 2020 • edited Loading

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 16, 2020

conda-forge-linter commented Jun 17, 2020

isuruf commented Jun 23, 2020

joseph-zhong commented Jun 23, 2020

isuruf commented Jun 23, 2020

joseph-zhong commented Jun 23, 2020

nicks commented Jun 23, 2020

joseph-zhong commented Jun 24, 2020 • edited Loading

nicks commented Jul 22, 2020

joseph-zhong commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

joseph-zhong commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

conda-forge-linter commented Jul 23, 2020

chrisburr Jul 24, 2020

Choose a reason for hiding this comment

chrisburr Jul 24, 2020

Choose a reason for hiding this comment

chrisburr commented Jul 24, 2020

joseph-zhong commented Jul 28, 2020 • edited Loading

joseph-zhong commented Jun 16, 2020 •

edited

Loading

joseph-zhong commented Jun 24, 2020 •

edited

Loading

joseph-zhong commented Jul 28, 2020 •

edited

Loading