Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output all packages resulting from split in version 1.31.0 #24

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

iisakkirotko
Copy link
Contributor

@iisakkirotko iisakkirotko commented Apr 18, 2024

Checklist

In solara version 1.31.0, the package was split into different parts:

  • The pytest plugin became pytest-ipywidgets
  • Solara itself was split into solara-ui and solara-server

These packages are all in the widgetti/solara repository, so it makes sense to output them all from here. This should output all packages, and ensure correct interdependency.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@iisakkirotko iisakkirotko force-pushed the package-split branch 12 times, most recently from 905b857 to da8bbf6 Compare April 19, 2024 15:29
@maartenbreddels
Copy link
Contributor

@dhirschfeld we spend quite some time understanding why this recipe fails with:

export PREFIX=/home/conda/feedstock_root/build_artifacts/solara_1713540897963/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold
export SRC_DIR=/home/conda/feedstock_root/build_artifacts/solara_1713540897963/test_tmp
import: 'solara_assets'
import: 'solara_assets'
+ pip check
solara-assets 1.31.0 requires solara, which is not installed.
WARNING: Tests failed for solara-assets-1.31.0-pyhca7485f_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: solara-assets-1.31.0-pyhca7485f_0.conda

Can you check this out, if you maybe understand what is going on?

cheers,

Maarten

@dhirschfeld
Copy link
Member

I'm happy to take a look, though I doubt I have any greater insight on the issue. I probably can't get to it until the weekend though.

@maartenbreddels
Copy link
Contributor

We are lost right now, so a fresh look might help, 🙏

@dhirschfeld
Copy link
Member

It seems that it's just pip check which is failing. It's complaining that solara isn't installed when it quite clearly is:

+ pip check
solara-assets 1.31.0 requires solara, which is not installed.

...but the solara conda pacakage is installed:

    sniffio:                   1.3.1-pyhd8ed1ab_0         conda-forge
    solara:                    1.31.0-pyhd8ed1ab_0        local      
    solara-assets:             1.31.0-pyhca7485f_0        local      
    solara-server:             1.31.0-pyhca7485f_0        local      
    solara-ui:                 1.31.0-pyhd8ed1ab_0        local      
    stack_data:                0.6.2-pyhd8ed1ab_0         conda-forge

IMO pip check can be a nice safety net when it works, but IME it reasonably often fails to understand conda packaging.

My view is that it's a tool designed for a different ecosystem and if it works, great - it provides a sense check on your deps, but if it fails for obviously spurious reasons then I just comment it out.

My recommendation here is to just comment out pip check for solara_assets.

@dhirschfeld
Copy link
Member

xref: pypa/pip#11159 (comment)

@maartenbreddels
Copy link
Contributor

I think given that solara-assets is pretty simple, we could skip it indeed. Thanks for this!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@iisakkirotko iisakkirotko merged commit f3439c4 into conda-forge:main Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants