Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin runtime requirements on minor versions #36

Merged

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Apr 8, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: James Munro <[email protected]>
@jjerphan
Copy link
Member Author

jjerphan commented Apr 8, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/snappy-feedstock/actions/runs/8595901863.

Signed-off-by: Julien Jerphanion <[email protected]>
@xhochy
Copy link
Member

xhochy commented Apr 8, 2024

Will merge once we have the repodata patch in place and adjusted conda-forge-pinning.

@pentschev
Copy link

Thanks for working on this. I was just about to file an issue in https://github.com/conda-forge/orc-feedstock as I've observed the snappy upgrade has broken https://github.com/conda-forge/arrow-feedstock :

$ python -c "import pyarrow"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/conda/envs/arrow/lib/python3.9/site-packages/pyarrow/__init__.py", line 65, in <module>
    import pyarrow.lib as _lib
ImportError: /opt/conda/envs/arrow/lib/python3.9/site-packages/pyarrow/../../.././liborc.so: undefined symbol: _ZN6snappy11RawCompressEPKcmPcPm=

I'm not familiar with all behavior this pin will have, will it prevent orc from installing snappy>=1.2, or would other changes be required? Perhaps listing snappy in conda-forge-pinning-feedstock’s arch_rebuild would be needed?

@jjerphan
Copy link
Member Author

jjerphan commented Apr 8, 2024

I'm not familiar with all behavior this pin will have, will it prevent orc from installing snappy>=1.2, or would other changes be required? Perhaps listing snappy in conda-forge-pinning-feedstock’s arch_rebuild would be needed?

conda-forge/conda-forge-repodata-patches-feedstock#699 addresses it.

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Copy link
Member Author

jjerphan commented Apr 8, 2024

Must we introduce stricter tests for osx and linux builds' shared objects SONAMEs?

@xhochy xhochy merged commit 16114fe into conda-forge:main Apr 8, 2024
8 checks passed
@xhochy
Copy link
Member

xhochy commented Apr 8, 2024

🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants