Avoid to install vendored dirent.h and add cdt expat as dependency #40

traversaro · 2021-05-17T12:59:50Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Fix #39 .
Backport of simbody/simbody#716 .

conda-forge-linter · 2021-05-17T12:59:55Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro · 2021-05-17T13:00:24Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2021.05.17.11.22.30

traversaro · 2021-05-17T13:24:16Z

Linux build is failing with:

[ 63%] Linking CXX executable ../../../simbody-visualizer
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: warning: libexpat.so.1, needed by /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so, not found (try using -rpath or -rpath-link)
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ErrorString'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_SetUserData'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetCurrentLineNumber'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ParserFree'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_SetElementHandler'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetCurrentColumnNumber'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetErrorCode'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetBuffer'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ParserCreate'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_Parse'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ParseBuffer'
collect2: error: ld returned 1 exit status
make[2]: *** [simbody-visualizer] Error 1
make[1]: *** [Simbody/Visualizer/simbody-visualizer/CMakeFiles/simbody-visualizer.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 63%] Linking CXX executable ../../TestCustomConstraints
[ 63%] Built target TestCustomConstraints
make: *** [all] Error 2

Probably this is not related to the specific change of the PR, but due to the re-rendering of the feedstock.

traversaro · 2021-05-17T13:27:41Z

Linux build is failing with:

[ 63%] Linking CXX executable ../../../simbody-visualizer
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: warning: libexpat.so.1, needed by /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so, not found (try using -rpath or -rpath-link)
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ErrorString'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_SetUserData'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetCurrentLineNumber'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ParserFree'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_SetElementHandler'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetCurrentColumnNumber'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetErrorCode'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_GetBuffer'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ParserCreate'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_Parse'
/home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/simbody_1621256585314/_build_env/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib/libGL.so: undefined reference to `XML_ParseBuffer'
collect2: error: ld returned 1 exit status
make[2]: *** [simbody-visualizer] Error 1
make[1]: *** [Simbody/Visualizer/simbody-visualizer/CMakeFiles/simbody-visualizer.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 63%] Linking CXX executable ../../TestCustomConstraints
[ 63%] Built target TestCustomConstraints
make: *** [all] Error 2

Probably this is not related to the specific change of the PR, but due to the re-rendering of the feedstock.

Hopefully this will be fixed by 931483e .

traversaro · 2021-05-17T14:48:46Z

Hopefully this will be fixed by 931483e .

The fix worked correctly.

moorepants · 2021-05-17T14:48:49Z

Are there any adverse consequences for removing this header? for example for packages that rely on it being there but don't have it installed via another method?

traversaro · 2021-05-17T14:50:36Z

Are there any adverse consequences for removing this header? for example for packages that rely on it being there but don't have it installed via another method?

This is indeed a possibility. If you prefer, we can add dirent as a run dependency on Windows, that should ensure that any downstream project that relies on dirent.h being installed will continue to work.

moorepants · 2021-05-17T15:34:15Z

That sounds like the right thing to do.

traversaro · 2021-05-17T15:40:27Z

That sounds like the right thing to do.

Done in 58cb699 .

moorepants · 2021-05-17T16:44:34Z

LGTM. Thanks!

traversaro added 2 commits May 17, 2021 14:56

Create 716.patch

e64c90c

Update meta.yaml

71fa33f

traversaro requested review from chrisdembia and moorepants as code owners May 17, 2021 12:59

Update meta.yaml

5a15cb7

traversaro mentioned this pull request May 17, 2021

conda:Tags:Default@windows-2019@Release CI job failure robotology/robotology-superbuild#712

Closed

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.1, and co…

ade1cb5

…nda-forge-pinning 2021.05.17.11.22.30

Update meta.yaml

931483e

traversaro changed the title ~~Avoid to install vendored dirent.h~~ Avoid to install vendored dirent.h and add cdt expat as dependency May 17, 2021

Address reviewers comment

58cb699

moorepants merged commit 4d12b7a into conda-forge:master May 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid to install vendored dirent.h and add cdt expat as dependency #40

Avoid to install vendored dirent.h and add cdt expat as dependency #40

traversaro commented May 17, 2021 •

edited

Loading

conda-forge-linter commented May 17, 2021

traversaro commented May 17, 2021

traversaro commented May 17, 2021

traversaro commented May 17, 2021

traversaro commented May 17, 2021

moorepants commented May 17, 2021

traversaro commented May 17, 2021 •

edited

Loading

moorepants commented May 17, 2021

traversaro commented May 17, 2021 •

edited

Loading

moorepants commented May 17, 2021

Avoid to install vendored dirent.h and add cdt expat as dependency #40

Avoid to install vendored dirent.h and add cdt expat as dependency #40

Conversation

traversaro commented May 17, 2021 • edited Loading

conda-forge-linter commented May 17, 2021

traversaro commented May 17, 2021

traversaro commented May 17, 2021

traversaro commented May 17, 2021

traversaro commented May 17, 2021

moorepants commented May 17, 2021

traversaro commented May 17, 2021 • edited Loading

moorepants commented May 17, 2021

traversaro commented May 17, 2021 • edited Loading

moorepants commented May 17, 2021

traversaro commented May 17, 2021 •

edited

Loading

traversaro commented May 17, 2021 •

edited

Loading

traversaro commented May 17, 2021 •

edited

Loading