Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Move pooch to a test dependency #248

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 8, 2023

Remove pooch as an install dependency to avoid distributing optional dependencies without user request.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

* Remove pooch as an install dependency to avoid distributing optional
  dependencies without user request.
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

Thank you for already taking actions to mitigate the failures, @h-vetinari. 🙏

@h-vetinari
Copy link
Member

OK, this is currently some pypy variants, so let's put this in. Thanks for the issue & pr @matthewfeickert!

@h-vetinari h-vetinari marked this pull request as ready for review September 13, 2023 12:04
@h-vetinari h-vetinari merged commit d5fd7f7 into conda-forge:main Sep 13, 2023
@matthewfeickert matthewfeickert deleted the mnt/move-pooch-to-test-dependency branch September 13, 2023 14:11
@matthewfeickert
Copy link
Member Author

Thanks very much for fixing everything @h-vetinari, as well as for your help, information, and direction on all of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pooch runtime dependency intended? Why is pooch being picked up at install time?
2 participants