Pin cddlib to the release that 8.2 is using #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
20 tasks
as that one is missing cdd_both_reps. We need a separate workaround to ignore the "iteration" lines in the output that 0.94h introduced.
isuruf
reviewed
Jul 17, 2018
recipe/meta.yaml
Outdated
| - cddlib >=0.94g | ||
| # SageMath uses 0.94g but that does not seem to be packaged in conda-forge, | ||
| # 0.94j does not have cdd_both_reps anymore | ||
| - cddlib >=0.94g,<0.94j |
There was a problem hiding this comment.
Can you fix this to be >=1!0.94g,<1!0.94j? Then we can merge the cddlib upgrade PR.
There was a problem hiding this comment.
Ok. I had thought that "1!" was the implicit epoch.
I was under the impression that "1!" is the implicit prefix. Apparently it isn't.
isuruf
approved these changes
Jul 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the output of cddlib has changed in 0.94h or 0.94i.