Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for krb5120 #236

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update krb5120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3971426494, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mfansler
Copy link
Member

Windows build fails on miktex post-link script. Seems like someone has worked on a fix, but that the miktex recipe no longer builds (see conda-forge/miktex-feedstock#22). But these issues are 20 months old, so presumably others have encountered and been working around them. 👀

@h-vetinari
Copy link
Member

This PR is holding up rebuilds of various 4.1 packages that have something that requires newer krb5 coinstalled (e.g. conda-forge/r-arrow-feedstock#61).

Can we deactivate the miktex stuff on windows? That shouldn't be an essential part of the package anyway?

@h-vetinari
Copy link
Member

@conda-forge/r, the fact that this PR isn't merged is seriously compromising the usability of R 4.1 in conda-forge (and blocking other migrations). Either we should drop 4.1 on unix or we need to get this PR merged.

@mfansler
Copy link
Member

mfansler commented Apr 7, 2023

@conda-forge/r, the fact that this PR isn't merged is seriously compromising the usability of R 4.1 in conda-forge (and blocking other migrations). Either we should drop 4.1 on unix or we need to get this PR merged.

@h-vetinari do you mean Windows instead of unix?

I think @isuruf was attempting a workaround on #243 that would also be applicable here.

@h-vetinari
Copy link
Member

h-vetinari commented Apr 7, 2023

@h-vetinari do you mean Windows instead of unix?

No, I mean dropping 4.1 for unix, but conda-forge wide. Unless this PR is merged, 4.1 is not resolvable anymore in conda-forge/r-arrow-feedstock#61 (for example, but not only, given the cross-references here), and I needed to drop it to move forward (because this affects upstream arrow CI which includes conda builds). That means r-arrow is now built for 4.2 on unix and 4.1 on windows.

@mbargull
Copy link
Member

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits May 13, 2023 19:53
@mbargull mbargull merged commit c29cffd into conda-forge:4.1.x May 14, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-krb5120-0-1_h3dedd0 branch May 14, 2023 07:26
@h-vetinari
Copy link
Member

Amazing news, thanks a lot! 🙏 🥳

@mbargull
Copy link
Member

Amazing news, thanks a lot! pray partying_face

Thanks, @h-vetinari.
But beware that, for now, this is only for these migrations that were pending for a while...
In conda-forge/conda-forge-pinning-feedstock#4363 there is discussion whether Windows builds should be continued to be supported until we have newer R versions build for that platform.
(I merely help with r-base here but deliberately don't handle the majority of the work in maintaining the downstream packages 😏 . The good folks of @conda-forge/r are the deciders on what to do there 😉.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants