-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinating r-base updates #46
Comments
I think 4. is the most crucial for compatibility with the As a |
@dhirschfeld Would you like to take charge on this effort? As you can see in #34, I have regularly checked in on that issue without much success. I don't have the first idea how to manipulate tarballs on Anaconda Cloud.
The policy has been adopted, but that doesn't mean it's been executed. The r-base recipe has lots of patches that appear to be win-32 specific, so at some point someone needs to investigate to see which patches we can safely remove. |
Unfortunately I doubt I'll have time this year to look at the problem. I'd love for it to Just Work and think it's a very serious problem but since I can work around/avoid it for now it's not on my critical path and I'm completely swamped with other work :/ |
R 3.5.1 has been released (release notes) |
@bgruening In case it could be useful, I had created this Issue to track the various updates that have been discussed for r-base. |
Another to-do when we get the chance: install |
FYI the compiler rebuild and R update have reached |
Now that PR ( #61 ) is in, would be good to update this list accordingly. |
PR #61 implemented the following updates:
Both PR #60 and #61 edited the CI configuration files, so either or both of them succeeded in dropping support for win-32 because R 3.5.1 is no longer being uploaded to Anaconda Cloud. Strangely, although some of the win32 specific patches were deleted in PR #61, there are still 3 remaining: |
I've updated the checklist above, and also followed up on Issues #34 and conda-forge/staged-recipes#6690. Since it appears that all the issues have been addressed, I'm closing the issue. |
There are lots of changes to be made to the r-base recipe. We need to decide which changes we make simultaneously and which we do in independent stages:
Migrate to conda-build 3Migrate to Jinja2 compiler syntax #47Update to R 3.5.1 (to be released on July 2)Version 3.5.1 #56, build r-base against 3.4.1 and 3.5.1 conda-forge-pinning-feedstock#107Re-arrange Windows R layout to be the same as Unix #43Rebase on top of cf #57Let's see how this goes. #61{{native}}icu
on Windows r-stringi and r-stringr R 3.5 win64 packages being pulled from defaults instead of conda-forge staged-recipes#6690 Let's see how this goes. #61For me, the highest priority are the first two items. I propose we migrate to conda-build 3 and update to R 3.5.1 together as the next big change.
Re-arranging the Windows R layout to be the same as Unix is still a work-in-progress, and would involve updating the R package recipes to properly find the license files shipped with r-base. Thus I think this change should wait until after the big update to 3.5.1.
If we want to allow users to install Microsoft R Open from the defaults channel while also having access to non-R packages from conda-forge, we need to add
r-mutex 1.* anacondar_1
as a run dependency. I don't use Microsoft R Open, and don't fully understand the consequences of adding this dependency, so we'll need someone willing to take charge on this.conda-forge has dropped support for win-32 builds, and the r-base recipes has multiple patches for win-32, so at some point we should remove these if they are no longer relevant.
To get a sense of the changes that have taken place on the defaults r-base (it's currently at 3.5.0), check out PR #45.
The text was updated successfully, but these errors were encountered: