Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_export to pytorch #43

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Add run_export to pytorch #43

merged 2 commits into from
Jul 24, 2021

Conversation

AntoinePrv
Copy link
Contributor

@AntoinePrv AntoinePrv commented May 20, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Pytorch ABI is not stable, so libraries building Pyorch extensions should use the same minor version of Pyorch as the one used to build. See for instance conda-forge/pytorch_scatter-feedstock#24.

@AntoinePrv
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. activate_in_script is not a valid subsection name.

For recipe:

  • It looks like the 'pytorch-cpu' output doesn't have any tests.

@hmaarrfk
Copy link
Contributor

These packages are really hard to build. @isuruf do you think it is acceptable to write a metadata patch to add the run exports? Then we can skip bumping the building number

recipe/meta.yaml Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

jaimergp commented Jun 25, 2021

@hmaarrfk: do you think it is acceptable to write a metadata patch to add the run exports?

run_exports is only available at channeldata.json or the package itself (e.g. see conda/conda-build#3583, conda/conda-build#3617), and afaik we don't patch channeldata, only repodata :/

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@hmaarrfk
Copy link
Contributor

@AntoinePrv are you able to rebase (or merge from) master and rebuild I think this is something I want to get in the next big pytorch push.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. activate_in_script is not a valid subsection name.

For recipe:

  • It looks like the 'pytorch-cpu' output doesn't have any tests.

@AntoinePrv
Copy link
Contributor Author

@hmaarrfk Done

@hmaarrfk hmaarrfk merged commit ec1566f into conda-forge:master Jul 24, 2021
@hmaarrfk
Copy link
Contributor

Thanks. lets see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants