Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OSX builds to avoid co-installed incompatible versions of OpenMP #244

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #243.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Disable OMP on OSX due to known upstream incompatibilities Jun 23, 2024
@hmaarrfk
Copy link
Contributor

lets see if we can recreate the failure in #245

@hmaarrfk hmaarrfk changed the title Disable OMP on OSX due to known upstream incompatibilities Adjust OSX builds to avoid co-installed incompatible versions of OpenMP Jun 25, 2024
recipe/build_pytorch.sh Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

@isuruf for my knowledge, have you tested the proposed fix? or do I need to think of a testing plan? My 8GB MacBook might not be able to compile this locally.

Maybe I'll have to upload the build artifacts?

@hmaarrfk
Copy link
Contributor

As a followup, are we concerned to overloading the large runners? Should I continue to cancel the linux jobs even once we merge?

@isuruf
Copy link
Member

isuruf commented Jun 25, 2024

Yes, I tested. You can also test this in an existing installation, by doing

pushd $SP_DIR/torch
for f in bin/* lib/* share/* include/*; do
  if [[ -e "$PREFIX/$f" ]]; then
    rm -rf $f
    ln -sf $PREFIX/$f $PWD/$f
  fi
done

@hmaarrfk
Copy link
Contributor

You are correct:

cd ${CONDA_PREFIX}/lib/python3.1/site-packages/torch/lib
rm libomp.dylib
ln -s ${CONDA_PREFIX}/lib/libomp.dylib
cd 
python -c "import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)"

no longer segfaults

@hmaarrfk
Copy link
Contributor

Thank you for troubleshooting for this with me!

@hmaarrfk
Copy link
Contributor

I'm going to merge and cancel the linux builds to save linux users a 500MB+ download.

@hmaarrfk hmaarrfk merged commit b362c03 into conda-forge:main Jun 26, 2024
18 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants