Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_abi to run_constrained (for 3.6) #321

Closed

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Mar 5, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham force-pushed the add_run_constrained_3.6 branch 2 times, most recently from 45c4226 to 1e83b19 Compare March 5, 2020 04:12
@jakirkham jakirkham force-pushed the add_run_constrained_3.6 branch from 1e83b19 to 178b513 Compare March 5, 2020 04:13
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with this change, this wouldn't fix your issue.

@jakirkham
Copy link
Member Author

Hmm...ok. What should we be doing instead? 🙂

@isuruf
Copy link
Member

isuruf commented Mar 5, 2020

It's a bug/feature of conda solver. We should update this to 3.6.10. Can you click the allow edits from maintainers button?

@jakirkham
Copy link
Member Author

Ack! Ok that makes sense. Should we be hot-fixes old python packages then?

I would, but GitHub doesn't show it 😞

@jakirkham
Copy link
Member Author

Are there other changes we need?

@isuruf
Copy link
Member

isuruf commented Mar 5, 2020

@mbargull
Copy link
Member

mbargull commented Mar 5, 2020

It's a bug/feature of conda solver.

Can you elaborate and/or point me to CI logs?

@isuruf
Copy link
Member

isuruf commented Mar 5, 2020

@mbargull, pypy python version was 3.6.9 and cpython version was 3.6.7. In current_repodata.json, only pypy 3.6.9 was there. This means that conda install python=3.6 was resolved with the pypy python version 3.6.9 even though it has a track_features entry.

@mbargull
Copy link
Member

mbargull commented Mar 5, 2020

Ah, that current_repodata.json thing... Makes sense, thank you!

@jakirkham
Copy link
Member Author

How do we avoid this issue cropping up in the future?

@jakirkham
Copy link
Member Author

Handled in PR ( #323 ).

@jakirkham jakirkham closed this Mar 5, 2020
@jakirkham jakirkham deleted the add_run_constrained_3.6 branch March 5, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants