-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python_abi
to run_constrained
(for 3.6)
#321
Add python_abi
to run_constrained
(for 3.6)
#321
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
45c4226
to
1e83b19
Compare
1e83b19
to
178b513
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree with this change, this wouldn't fix your issue.
Hmm...ok. What should we be doing instead? 🙂 |
It's a bug/feature of conda solver. We should update this to 3.6.10. Can you click the allow edits from maintainers button? |
Ack! Ok that makes sense. Should we be hot-fixes old I would, but GitHub doesn't show it 😞 |
Are there other changes we need? |
We need https://github.com/conda-forge/python-feedstock/blob/3.7/recipe/patches/0020-Use-ranlib-from-env-if-env-variable-is-set.patch backported to avoid a bug introduced between 3.6.7 and 3.6.10 |
Can you elaborate and/or point me to CI logs? |
@mbargull, pypy python version was 3.6.9 and cpython version was 3.6.7. In |
Ah, that |
How do we avoid this issue cropping up in the future? |
Handled in PR ( #323 ). |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)