-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: testing 1.4.3 #14
Conversation
…nda-forge-pinning 2020.05.27.14.19.32
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Here's the status of this test:
Note about the Mac unicode failure:This problem is not specific to conda-forge. Any Mac user with a recent version of git will encounter the following error when they clone the
I called What's the cause? Apparently something weird can happen when transferring files with non-ASCII names to/from the Mac filesystem. The PySpice repo contains two files with a non-ascii character (é):
I am not knowledgeable on the subject of "precomposed" vs. "decomposed" unicode, but here are some possible solutions:
Again, this is not a problem for our conda-forge recipe in general, since we will normally build from a tarball, not from git. |
@FabriceSalvaire OK, I fixed the issue on Windows. (It's related to conda/conda-build#3965.) As mentioned above, the Mac problem is not a "real" problem. So I think this PR demonstrates that we'll be ready to publish conda packages for v1.4.3 whenever you tag it in the PySpice repo. |
@stuarteberg looks good ! I got a Windows machine to test ! but must read conda-forge doc ... |
Since this is just a PR and has not yet been merged to master, the package is not uploaded to anaconda.org. There is no convenient way to test it. But I have just rebuilt this recipe locally, and uploaded it to my personal channel for you to test:
I won't be able to do that frequently, but maybe that's enough for a basic evaluation of this recipe so far. |
v1.4.3 include #14 and CI
This PR tests the latest git rev of pyspice, which isn't tagged yet.
See #13
Checklist
0
(if the version changed)conda-smithy