Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patches for glibc-detection, numpy segfault on win, get_python_lib #47

Merged
merged 3 commits into from
Jul 4, 2021

Conversation

h-vetinari
Copy link
Member

Fixing https://foss.heptapod.net/pypy/pypy/-/issues/3502 as suggested by @mattip:

PyPy issue is fixed. Is it worth making a patch and releasing a new pypy7.3.5 build? The next PyPy release will probably be a few months coming, and I don't know how common it is to use PyPy + centos7

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the patch fixes the os.confstr incompatibility, I don't know if the cost to users and/or conda-forge to update the build number for this is worth it. Does it dsrupt anything to accept it?

@h-vetinari
Copy link
Member Author

h-vetinari commented Jul 2, 2021

I don't know if the cost to users and/or conda-forge to update the build number for this is worth it. Does it dsrupt anything to accept it?

It's a normal part of the process. It means people using pypy download the new package when they update their environment (creating some more CDN traffic), but otherwise, the infrastructural costs are negligible (still takes reviewer time, of course, but you've done >90% of the work there by implementing the fix and approving it 🙃).

And of course, it helps with not having intermittent numpy build failures (like in conda-forge/numpy-feedstock#238), or someone wanting to run the numpy test suite on an AVX512 machine, etc. 😉

@mattip
Copy link
Contributor

mattip commented Jul 2, 2021

run the numpy test suite on an AVX512 machine

... but still stuck with CentOS6 which went EOL 7 months ago

@mattip
Copy link
Contributor

mattip commented Jul 2, 2021

I am working on more fixes for PyPy + Windows + NumPy, so maybe let's wait a day or two to see if I can add another patch here

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [25]

@mattip
Copy link
Contributor

mattip commented Jul 4, 2021

I pushed some more fixes:

  • renamed the patch @h-vetinari added since it will be part of pypyv7.3.6
  • added another patch that is also part of v7.3.6. It seems to solve the segfault on win64 when testing numpy
  • added a patch to fix the schema used in get_python_lib from distutils.sysconfig to make it match CPython's ersion. I limited it to windows, but I think the schema changes in both the distutil* patches should also apply to linux. @isuruf thoughts?

@mattip mattip force-pushed the glibc-detection branch from ff0a93d to 1206f87 Compare July 4, 2021 10:42
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip mattip force-pushed the glibc-detection branch from 1206f87 to 84606eb Compare July 4, 2021 10:44
@mattip
Copy link
Contributor

mattip commented Jul 4, 2021

The get_python_libs function is not commonly uses. NumPy uses it in runtests.py

@h-vetinari
Copy link
Member Author

Thanks Matti, LGTM! :)

@h-vetinari h-vetinari changed the title add patch for correct glibc-detection add patches for glibc-detection, numpy segfault on win, get_python_lib Jul 4, 2021
@h-vetinari
Copy link
Member Author

@isuruf, could you take a look here please? I'd love to unblock the win-pypy numpy build, which will likely still take another iteration after this.

@isuruf isuruf merged commit efda60d into conda-forge:master Jul 4, 2021
@h-vetinari
Copy link
Member Author

Thanks! :)

@h-vetinari h-vetinari deleted the glibc-detection branch July 4, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants