-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patches for glibc-detection, numpy segfault on win, get_python_lib
#47
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the patch fixes the os.confstr
incompatibility, I don't know if the cost to users and/or conda-forge to update the build number for this is worth it. Does it dsrupt anything to accept it?
It's a normal part of the process. It means people using pypy download the new package when they update their environment (creating some more CDN traffic), but otherwise, the infrastructural costs are negligible (still takes reviewer time, of course, but you've done >90% of the work there by implementing the fix and approving it 🙃). And of course, it helps with not having intermittent numpy build failures (like in conda-forge/numpy-feedstock#238), or someone wanting to run the numpy test suite on an AVX512 machine, etc. 😉 |
... but still stuck with CentOS6 which went EOL 7 months ago |
I am working on more fixes for PyPy + Windows + NumPy, so maybe let's wait a day or two to see if I can add another patch here |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
I pushed some more fixes:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The |
Thanks Matti, LGTM! :) |
get_python_lib
Thanks! :) |
Fixing https://foss.heptapod.net/pypy/pypy/-/issues/3502 as suggested by @mattip: